Fix various dump generation issues for VS4Mac #60995
Conversation
Fixes issue: dotnet#60932
crash report flag to be passed through to createdump for VS4Mac. Issue: dotnet#60775
…ignal ExceptionType
|
Tagging subscribers to this area: @tommcdon Issue DetailsThe createdump crash report can have multiple threads indicated as crashed. Fixes issue: #60932 Add new generate core dump IPC command that allows the generate crash report flag to be passed through to createdump for VS4Mac. Issue: #60775 VS4Mac needs to distinguish between WriteDump/no signal and unknown signal ExceptionType. Fix how the load bias is calculate for shared modules.
|
mikem8361
requested review from
hoyosjs,
kdubau and
josalem
and removed request for
marek-safar
|
diagnostics repo PR: dotnet/diagnostics#2715 |
| else | ||
| { | ||
| if (thread->Tid() == m_crashInfo.CrashThread()) | ||
| if (thread->ManagedExceptionObject() != 0) |
There was a problem hiding this comment.
One thing that I was thinking here: In the unwindThread paths we check for LastThrown and request flags on the ExceptionState and do (flags & Ex_IsUnhandled)
There was a problem hiding this comment.
So only use LastThrown if Ex_IsUnhandled is set?
There was a problem hiding this comment.
But how do I get this flag in createdump? It looks like an internal vm flag
There was a problem hiding this comment.
The DAC has an API to get the flags on an ExceptionState I thought.
mikem8361
force-pushed
the
vs4macfixes
branch
from
2215ac0
to
6f51441
Compare
ghost
locked as resolved and limited conversation to collaborators
The createdump crash report can have multiple threads indicated as crashed. Fixes issue: #60932
Add new generate core dump IPC command that allows the generate crash report flag to be passed through to createdump for VS4Mac. Issue: #60775
VS4Mac needs to distinguish between WriteDump/no signal and unknown signal ExceptionType.
Fix how the load bias is calculate for shared modules.