Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generate crash report flag (and other flags) to WriteDump diagnostics IPC message #60775

Closed
mikem8361 opened this issue Oct 22, 2021 · 2 comments
Assignees
Labels
area-Diagnostics-coreclr enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@mikem8361
Copy link
Member

Background and Motivation

The VS for Mac team needs a way to generate the crash report json file for hangs.

Proposed Feature

Add a flags argument to the Microsoft.Diagnostics.NETCore.Client.WriteDump/WriteDumpAsync API that enables crash report json and other logging options (verbose and log to file).

Also see issue: dotnet/diagnostics#2698

@mikem8361 mikem8361 added this to the 6.0.1 milestone Oct 22, 2021
@mikem8361 mikem8361 self-assigned this Oct 22, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Oct 22, 2021
@ghost
Copy link

ghost commented Oct 22, 2021

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Background and Motivation

The VS for Mac team needs a way to generate the crash report json file for hangs.

Proposed Feature

Add a flags argument to the Microsoft.Diagnostics.NETCore.Client.WriteDump/WriteDumpAsync API that enables crash report json and other logging options (verbose and log to file).

Also see issue: dotnet/diagnostics#2698

Author: mikem8361
Assignees: mikem8361
Labels:

area-Diagnostics-coreclr

Milestone: 6.0.1

@mikem8361 mikem8361 removed the untriaged New issue has not been triaged by the area owner label Oct 22, 2021
@noahfalk noahfalk added the enhancement Product code improvement that does NOT require public API changes/additions label Oct 25, 2021
@AraHaan
Copy link
Member

AraHaan commented Oct 27, 2021

I just commented on dotnet/diagnostics#2698.

mikem8361 added a commit to mikem8361/runtime that referenced this issue Oct 28, 2021
crash report flag to be passed through to createdump for VS4Mac.

Issue: dotnet#60775
mikem8361 added a commit that referenced this issue Nov 1, 2021
Fix dump generation issues for VS4Mac

Fixes issue: #60932

Fix how the load bias is calculate for shared modules

Add new generate core dump IPC command that allows the generate
crash report flag to be passed through to createdump for VS4Mac.

Issue: #60775

VS4Mac needs to distinguish between WriteDump/no signal and unknown signal ExceptionType

Change unknown signal exception type to 0
mikem8361 added a commit to mikem8361/runtime that referenced this issue Nov 1, 2021
The VS4Mac team found two issues preventing them from successfully diagnosing VS4Mac failures
on .NET:

1) Multiple "crashed" threads in the crash report json (dotnet#60932).
2) No flag or way to generate the crash report for hangs via the diagnostic server IPC commands (dotnet#60775).

Add new generate core dump IPC command that allows the generate crash report flag to be passed through to createdump for
VS4Mac. VS4Mac needs to distinguish between WriteDump/no signal and unknown signal ExceptionType. Change unknown signal
exception type to 0.

Issue: dotnet#60775

Fix how the load bias is calculate for shared modules

Local testing with the SOS tests. VS4Mac team testing and verification.

Low risk because it only affects createdump, dump IPC command and the runtime dump generation path.
@mikem8361 mikem8361 modified the milestones: 6.0.1, 6.0.x Nov 5, 2021
Anipik pushed a commit that referenced this issue Nov 9, 2021
The VS4Mac team found two issues preventing them from successfully diagnosing VS4Mac failures
on .NET:

1) Multiple "crashed" threads in the crash report json (#60932).
2) No flag or way to generate the crash report for hangs via the diagnostic server IPC commands (#60775).

Add new generate core dump IPC command that allows the generate crash report flag to be passed through to createdump for
VS4Mac. VS4Mac needs to distinguish between WriteDump/no signal and unknown signal ExceptionType. Change unknown signal
exception type to 0.

Issue: #60775

Fix how the load bias is calculate for shared modules

Local testing with the SOS tests. VS4Mac team testing and verification.

Low risk because it only affects createdump, dump IPC command and the runtime dump generation path.
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Diagnostics-coreclr enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

No branches or pull requests

3 participants