Fix dump generation issues for VS4Mac #61063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VS4Mac team found two issues preventing them from successfully diagnosing VS4Mac failures on .NET: 1) Multiple "crashed" threads in the crash report json (dotnet#60932). 2) No flag or way to generate the crash report for hangs via the diagnostic server IPC commands (dotnet#60775). Add new generate core dump IPC command that allows the generate crash report flag to be passed through to createdump for VS4Mac. VS4Mac needs to distinguish between WriteDump/no signal and unknown signal ExceptionType. Change unknown signal exception type to 0. Issue: dotnet#60775 Fix how the load bias is calculate for shared modules Local testing with the SOS tests. VS4Mac team testing and verification. Low risk because it only affects createdump, dump IPC command and the runtime dump generation path.
|
Tagging subscribers to this area: @tommcdon Issue DetailsCustomer ImpactThe VS4Mac team found two issues preventing them from successfully diagnosing VS4Mac failures
DetailsAdd new generate core dump IPC command that allows the generate crash report flag to be passed through to createdump for VS4Mac. VS4Mac needs to distinguish between WriteDump/no signal and unknown signal ExceptionType. Change unknown signal exception type to 0. Issue: #60775 Fix how the load bias is calculate for shared modules. TestingLocal testing with the SOS tests. VS4Mac team testing and verification. RiskLow risk because it only affects createdump, dump IPC command and the runtime dump generation path.
|
kdubau
approved these changes
Nov 1, 2021
janvorli
reviewed
Nov 1, 2021
hoyosjs
approved these changes
Nov 1, 2021
jeffschwMSFT
approved these changes
Nov 3, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer Impact
The VS4Mac team found two issues preventing them from successfully diagnosing VS4Mac failures
on .NET:
Details
Add new generate core dump IPC command that allows the generate crash report flag to be passed through to createdump for VS4Mac. VS4Mac needs to distinguish between WriteDump/no signal and unknown signal ExceptionType. Change unknown signal exception type to 0. Issue: #60775
Fix how the load bias is calculate for shared modules.
Testing
Local testing with the SOS tests. VS4Mac team testing and verification.
Risk
Low risk because it only affects createdump, dump IPC command and the runtime dump generation path.