-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert PR #60054: add Windows.Server.Core.20H2 #62253
Conversation
Tagging subscribers to this area: @safern |
@@ -132,11 +132,9 @@ jobs: | |||
- Windows.81.Amd64.Open | |||
- Windows.10.Amd64.ServerRS5.Open | |||
- Windows.10.Amd64.Server19H1.Open | |||
- Windows.10.Amd64.Server20H2.Open |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is not Server Core, are these failures happening on this SKU as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, sorry, these are in 20H2 non-Core, typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@safern Anything else?
Confirmed in https://dev.azure.com/dnceng/public/_build/results?buildId=1493013&view=results that this passes the runtime leg |
@ericstj mind signing off on this so we can unblock the build? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we tracking reenabling the whole queue? The linked issue is a single test.
@hoyosjs Do you have a preference on re-using the existing issue on the test failures vs. opening a new issue? |
Actually there's already an issue for this, #57947, which was missing a 20H2 entry, which I added |
@agocke I think of them as disjoint - one tracks enabling testing on the platform, the other one tracks a flaky test on that platform. Is this the only test we've observed with this behavior? |
I think dealing with failing tests is part of enabling the new platform. Either they need to be skipped and a bug filed, or the tests need to be fixed during bring-up. Either way, probably involves the product team. |
This will get easier once I add the new pipeline to separate what goes into rolling only and into PR 😄 |
This reverts commit efc8adb.
It looks like we have a number of test failures on Server.20H2, see #62205
Those tests will need to either be disabled or fixed before we enable this testing