Allow the inliner to substitute for small arguments #69068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we no longer have contextual nodes to indicate small arguments, this should be safe to do. For register arguments it does not matter and for stack arguments it is handled in codegen (for macOS arm64).
ghost
assigned 
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsSince we no longer have contextual nodes to indicate small arguments
|
|
/azp run Fuzzlyn |
|
Azure Pipelines successfully started running 1 pipeline(s). |
With small args we could end up inserting a cast between the arg node and a GT_RET_EXPR. We would not handle substituting this GT_RET_EXPR correctly. This reverts some more of the changes from 3e65d68 to make the scenario work again, by skipping over GT_RET_EXPR before creating the inlinee arg nodes.
|
|
|
/azp run Fuzzlyn |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
cc @dotnet/jit-contrib PTAL @AndyAyersMS |
AndyAyersMS
approved these changes
May 16, 2022
|
Spot-checked some of the regressions, they fell in the following categories:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we no longer have contextual nodes to indicate small arguments
this should be safe to do. For register arguments it does not matter and
for stack arguments it is handled in codegen (for macOS arm64).