Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable hot/cold splitting on Unix NativeAOT #71168

Merged

Conversation

amanasifkhalid
Copy link
Member

Follow-up to #70708. Because we have yet to test hot/cold splitting on NativeAOT, we should disable the feature if generateCFIUnwindCodes() is true.

Because it has yet to be tested, this commit disables
`opts.compProcedureSplitting` if `generateCFIUnwindCodes()` is true.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 22, 2022
@ghost ghost assigned amanasifkhalid Jun 22, 2022
@ghost
Copy link

ghost commented Jun 22, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Follow-up to #70708. Because we have yet to test hot/cold splitting on NativeAOT, we should disable the feature if generateCFIUnwindCodes() is true.

Author: amanasifkhalid
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@amanasifkhalid amanasifkhalid merged commit 3205533 into dotnet:main Jun 23, 2022
@amanasifkhalid amanasifkhalid deleted the disable-splitting-nativeaot branch June 23, 2022 14:54
@ghost ghost locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants