[wasm] reduce legacy interop usage #72021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsstill work in progress
|
pavelsavara
force-pushed
the
wasm_cswraps
branch
2 times, most recently
from
7f937e3
to
6dfa388
Compare
pavelsavara
force-pushed
the
wasm_cswraps
branch
2 times, most recently
from
7b0f983
to
e1fa625
Compare
pavelsavara
requested review from
thaystg,
radical,
lewing and
marek-safar
as code owners
pavelsavara
changed the title
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
force-pushed
the
wasm_cswraps
branch
from
21f8b8c
to
d0bb0df
Compare
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
maraf
approved these changes
Jul 15, 2022
radical
reviewed
Jul 15, 2022
...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Show resolved
Hide resolved
radical
reviewed
Jul 15, 2022
...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Show resolved
Hide resolved
radical
reviewed
Jul 15, 2022
...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated
Show resolved
Hide resolved
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
There is |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
# Conflicts: # src/mono/wasm/runtime/cjs/dotnet.cjs.lib.js # src/mono/wasm/runtime/exports.ts
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kg
reviewed
Jul 28, 2022
...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Show resolved
Hide resolved
kg
reviewed
Jul 28, 2022
...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated
Show resolved
Hide resolved
kg
reviewed
Jul 28, 2022
...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated
Show resolved
Hide resolved
kg
reviewed
Jul 28, 2022
...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated
Show resolved
Hide resolved
kg
approved these changes
Jul 28, 2022
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INTERNAL.mono_bind_static_methodwith public APIUrifrom managed method signatures and creating it's instance via reflection in hope to trim it out when not used. This could force the user code to keepUri(string uri)constructor alive by other means. But also save lot of download size.LegacyExports.net6-legacyfolder.mono_wasm_get_assembly_exportsmono_bind_methodand tomono_bind_static_methodthisArgtomono_bind_methodcswrapsandcwrapslaziness optional._wrap_delegate_gc_handle_as_functionusingmono_bind_methodmono_call_assembly_entry_pointusingmono_bind_method.call_method_refand replaced it withmono_bind_methodcall_static_methodjavaScriptExportsinmanaged-exports.tswhich support all the needs of the new interopalloc_stack_frameandinvoke_method_and_handle_exceptionexports.tsinto multiple filesNext PR
LegacyExportstrimablelegacyfolder separate optional ES6 module.mono_call_assembly_entry_pointto new interop [wasm] marshling call to assembly entrypoint via new interop #73156