Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] marshling call to assembly entrypoint via new interop #73156

Merged
merged 20 commits into from
Aug 4, 2022
Merged

[wasm] marshling call to assembly entrypoint via new interop #73156

merged 20 commits into from
Aug 4, 2022

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Aug 1, 2022 •
edited
Loading

  • added JavaScriptExports.CallEntrypoint replacing legacy mono_bind_assembly_entry_point
  • moved legacy imports and split RuntimeHelpers
  • simplified dotnet-legacy.d.ts
  • set_arg_type on manually written JavaScriptExports calls

@pavelsavara
- added JavaScriptExports.CallEntrypoint replacing legacy `mono_bin…
46e620c 
…d_assembly_entry_point`

- moved legacy imports and split `RuntimeHelpers`
@pavelsavara pavelsavara added this to the 7.0.0 milestone Aug 1, 2022
@pavelsavara pavelsavara requested review from kg and maraf August 1, 2022 14:38
@pavelsavara pavelsavara self-assigned this Aug 1, 2022
@ghost
Copy link

ghost commented Aug 1, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • added JavaScriptExports.CallEntrypoint replacing legacy mono_bind_assembly_entry_point
  • moved legacy imports and split RuntimeHelpers
Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 7.0.0

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

kg
kg reviewed Aug 3, 2022
View reviewed changes
src/mono/wasm/runtime/run.ts Outdated Show resolved Hide resolved
pavelsavara and others added 3 commits August 3, 2022 11:41
@pavelsavara
Merge branch 'main' into wasm_drop_legacy_entrypoint
2a85dd4
@pavelsavara @kg
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
27f232b 
…stem/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs

Co-authored-by: Katelyn Gadd <kg@luminance.org>
@pavelsavara
feedback
0a2156f
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara mentioned this pull request Aug 3, 2022
Merged
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara marked this pull request as ready for review August 3, 2022 21:44
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Merge branch 'main' into wasm_drop_legacy_entrypoint
af9bb66 
# Conflicts:
#	src/mono/wasm/runtime/dotnet.d.ts
#	src/mono/wasm/runtime/exports.ts
#	src/mono/wasm/runtime/imports.ts
#	src/mono/wasm/runtime/managed-exports.ts
#	src/mono/wasm/runtime/net6-legacy/method-calls.ts
#	src/mono/wasm/runtime/startup.ts
pavelsavara and others added 4 commits August 4, 2022 09:47
@pavelsavara
types cleanup
d6c8330
@pavelsavara @maraf
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
f1a77d3 
…stem/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs

Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
3763a30 
…stem/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs

Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
00f8f08 
…stem/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs

Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

pavelsavara commented Aug 4, 2022 •
edited
Loading 

WebAssembly.Browser.HotReload.Test
"MONO_WASM: onConfigLoaded() failed: {}"

is #73330 fix should be #73366

System.Text.Json.Tests
System.NotSupportedException : The deserialization constructor for type 'System.Tuple`1[System.Int32]' contains parameters with null names.

is #73347

Debugger failures are #73342

@pavelsavara pavelsavara merged commit 44cb67e into dotnet:main Aug 4, 2022
@lewing
Copy link
Member

lewing commented Aug 14, 2022 •
edited
Loading

for 8 we should consider emitting a Task<int> wrapper directly.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 14, 2022
@pavelsavara pavelsavara deleted the wasm_drop_legacy_entrypoint branch November 29, 2022 16:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kg kg kg left review comments

@maraf maraf maraf approved these changes

@radical radical Awaiting requested review from radical

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@pavelsavara @lewing @kg @maraf @radical