Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlatformNotSupportedException for UNIX domain sockets on iOS/tvOS #73374

Merged
merged 29 commits into from
Aug 9, 2022
Merged

PlatformNotSupportedException for UNIX domain sockets on iOS/tvOS #73374

merged 29 commits into from
Aug 9, 2022

Commits on Aug 4, 2022

  1. PNSE for domain sockets on iOS/tvOS

    @directhex
    directhex committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    87f7db3 View commit details
    Browse the repository at this point in the history

  2. Re-enable some tests which SHOULD now throw PNSE

    @directhex
    directhex committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    d17c748 View commit details
    Browse the repository at this point in the history

  3. Try handling Catalyst==iOS case better

    @directhex
    directhex committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    401a14d View commit details
    Browse the repository at this point in the history

  4. Move "sockets supported" check _before_ "socket path name too long" c… 

    …heck
    @directhex
    directhex committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    394cbfb View commit details
    Browse the repository at this point in the history

  5. Newer API, from Jan

    @directhex
    directhex committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    2f7ff83 View commit details
    Browse the repository at this point in the history

  6. Skip various tests on iOS/tvOS explicitly. 

    The same ones which fail on Linux Bionic, which has a similar problem
    @directhex
    directhex committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    995cf18 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2022

  1. Update src/libraries/Common/src/System/Net/SocketProtocolSupportPal.cs 

    Co-authored-by: Theodore Tsirpanis <teo@tsirpanis.gr>
    @directhex @teo-tsirpanis
    directhex and teo-tsirpanis authored Aug 5, 2022
    Configuration menu
    Copy the full SHA
    f383463 View commit details
    Browse the repository at this point in the history

  2. Try to mark up unrunnable dotnet#67853 tests, and reenable the rest t… 

    …o see
    @directhex
    directhex committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    489e1d9 View commit details
    Browse the repository at this point in the history

  3. Maybe mkfifo works after all? Try it out

    @directhex
    directhex committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    437fd79 View commit details
    Browse the repository at this point in the history

  4. YOLO

    @directhex
    directhex committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    99771fa View commit details
    Browse the repository at this point in the history

  5. YOLO2

    @directhex
    directhex committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    17e9b62 View commit details
    Browse the repository at this point in the history

  6. Actually run UDS tests on iOS derivs

    @directhex
    directhex committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    41baae1 View commit details
    Browse the repository at this point in the history

  7. Shrink socket path, just for sanity testing

    @directhex
    directhex committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    818b934 View commit details
    Browse the repository at this point in the history

  8. Make test not increase UDS path by 1-32 characters

    @directhex
    directhex committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    855fe09 View commit details
    Browse the repository at this point in the history

  9. Better approach

    @directhex
    directhex committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    227bbe9 View commit details
    Browse the repository at this point in the history

  10. Limit last change to 32 chars of randomness

    @directhex
    directhex committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    d814cc0 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2022

  1. Annotate Assert, since just 'True != False' is unhelpful

    @directhex
    directhex committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    0d38fb8 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. Okay, CONFIRMED: PNSE on iOS/tvOS

    @directhex
    directhex committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    d79e293 View commit details
    Browse the repository at this point in the history

  2. Try to fix up UDS-specific test failures on iOS/tvOS

    @directhex
    directhex committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    e7ab373 View commit details
    Browse the repository at this point in the history

  3. Revert change which only benefited tvOS/iOS UDS

    @directhex
    directhex committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    4e763c4 View commit details
    Browse the repository at this point in the history

  4. Mark more tests as unpassable due to PNSE

    @directhex
    directhex committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    80c4b47 View commit details
    Browse the repository at this point in the history

  5. Re-ActiveIssue tests failing due to dotnet#67853 bugs, not UDS bugs

    @directhex
    directhex committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    24023e4 View commit details
    Browse the repository at this point in the history

  6. Latest test results

    @directhex
    directhex committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    b4c1c5b View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into PNSE-domain-sockets-on-ios-tvos

    @directhex
    directhex authored Aug 8, 2022
    Configuration menu
    Copy the full SHA
    7514e6f View commit details
    Browse the repository at this point in the history

  8. Move tvOS/iOS hardcode to SocketProtocolSupportPal.Unix.cs

    @directhex
    directhex committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    b3db23c View commit details
    Browse the repository at this point in the history

  9. Use Socket.OSSupportsUnixDomainSockets

    @directhex
    directhex committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    61ca917 View commit details
    Browse the repository at this point in the history

  10. Clearer explanation on Bionic skips

    @directhex
    directhex committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    d21e3cc View commit details
    Browse the repository at this point in the history

  11. Replace accidental Theory->Fact swaps back to Theory

    @directhex
    directhex committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    6ba57a2 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2022

  1. I strongly disagree with this, but we have tests explicitly looking f… 

    …or it
    @directhex
    directhex committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    e46997e View commit details
    Browse the repository at this point in the history