-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0-rc1] Don't set PublishAot in SDK by default #74048
[release/7.0-rc1] Don't set PublishAot in SDK by default #74048
Conversation
/azp run runtime-wasm |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Can we add rc1 branch for runtime-wasm? it will be useful for validations. |
It's not a change for this pull request. These props/targets are only included in NativeAOT test legs in this repo. SDK repo promotes them to being more than that but that's not observable here because we use the old targets that came with the SDK everywhere outside NativeAOT testing. That's why this wasn't broken in this repo originally either. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the check to ensure that the SDK path doesn't set the PublishAot property.
The plan for PublishAOT
can be found here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
Backport of #74046 to release/7.0-rc1
/cc @MichalStrehovsky @sbomer
Customer Impact
Testing
Risk
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.