[release/7.0] Remove assert from Http3Connection.SendAsync

[rzikm]

Manual backport of #74348 to release/7.0
Fixes #74162.

cc: @danmoseley

Customer Impact

None, this change affects only tests (Asserts don't run in Release configuration). We have seen an increased number of crashes on Debug runs on Alpine Linux where we recently enabled HTTP/3 test coverage (#74162). This PR serves to mainly de-noise CI reports.

Testing

Functional tests pass on CI, and the affected test was run many times in a tight loop on the affected configuration.

Risk

Low, test only change.

[dotnet-issue-labeler]

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

---

• Use buffer.Length as the source of truth for ReadDirectoryChanges ([release/7.0-rc1] Use buffer.Length as the source of truth for ReadDirectoryChanges' nBufferLength #74023)
• [release/7.0-rc1] [wasm][debugger] Hide members from classes that don't have debug information ([release/7.0-rc1] [wasm][debugger] Hide members from classes that don't have debug information #74029)
• Product dependencies in Versions.props must be on the latest patch version for libraries dependencies ([release/7.0-rc1] Product dependencies in Versions.props must be on the latest patch version for libraries dependencies #74024)
• Don't set PublishAot in SDK by default ([release/7.0-rc1] Don't set PublishAot in SDK by default #74048)
• Add missing .npmrc ([release/7.0-rc1] [wasm] Add missing .npmrc in sample #74039)
• [release/7.0-rc1] [mono] Implement missing functionality for cctor invocation ([release/7.0-rc1] [mono] Implement missing functionality for cctor invocation #74043)
• [release/7.0-rc1] Optimized string.Replace(char, char) ([release/7.0-rc1] Optimized string.Replace(char, char) #74047)
• [release/7.0-rc1] Workload changes - account for SDK bands and use archives ([release/7.0-rc1] Workload changes - account for SDK bands and use archives #74054)
• [release/7.0] Update dependencies from dotnet/llvm-project dotnet/hotreload-utils dotnet/runtime-assets ([release/7.0] Update dependencies from dotnet/llvm-project dotnet/hotreload-utils dotnet/runtime-assets #74074)
• Vectorize {Last}IndexOf{Any}{Except} without code duplication (Vectorize {Last}IndexOf{Any} and {Last}IndexOfAnyExcept without code duplication #73768) ([release/7.0-rc1] Vectorize {Last}IndexOf{Any}{Except} without code duplication #74086)
• [release/7.0-rc1] perf pipeline: Switch to node 14.x ([release/7.0-rc1] perf pipeline: Switch to node 14.x #74089)
• Don't fail the test when the file is in use, fixes Test failure System.IO.Tests.RandomAccess_GetLength.ReturnsActualLengthForDevices(options: Asynchronous) #73925 ([release/7.0-rc1] Don't fail the test when the file is in use #74094)
• [release/7.0-rc1] Fix auto layout algorithm to compute structure alignment correctly ([release/7.0-rc1] Fix auto layout algorithm to compute structure alignment correctly #74091)
• [release/7.0-rc1] Add Arm64 PGO/IBC to Windows and Linux builds ([release/7.0-rc1] Add Arm64 PGO/IBC to Windows and Linux builds #74098)
• [release/7.0-rc1] Set configureplatform.make prerelease to 0 ([release/7.0-rc1] Set configureplatform.make prerelease to 0 #74103)
• [release/7.0-rc1] Fix nullable annotations on generic math interfaces ([release/7.0-rc1] Fix nullable annotations on generic math interfaces #74116)
• [release/7.0-rc1] Move runtimeconfig.template.json stuff to csproj ([release/7.0-rc1] Move runtimeconfig.template.json stuff to csproj #74144)
• [release/7.0-rc1] [NativeAOT] Add method parameter names to stack trace if available ([release/7.0-rc1] [NativeAOT] Add method parameter names to stack trace if available #74145)
• [Ppc64le] bug fixes ([Ppc64le] bug fixes #74131)
• Improve ControlledExecution tests ([release/7.0-rc1] Improve ControlledExecution tests #74186)
• Shorten the workload name even more ([release/7.0-rc1] [workloads] Shorten the workload name even more #74176)
• [release/7.0-rc1] Disable Int128 use in by value ABI scenarios, and fix field layout behavior ([release/7.0-rc1] Disable Int128 use in by value ABI scenarios, and fix field layout behavior #74279)
• Don't NativeAOT crossgen on ARM64 ([release/7.0-rc1] Don't NativeAOT crossgen on ARM64 #74221)
• [release/7.0-rc1] Add a way to suppress all trimming warnings ([release/7.0-rc1] Add a way to suppress all trimming warnings #74220)
• Don't track current field of state machines ([release/7.0-rc1] Don't track current field of state machines #74216)
• [release/7.0] Update arcade to 7.0.0-beta.22418.4 ([release/7.0-rc1] Update arcade to 7.0.0-beta.22418.4 #74210)
• [release/7.0-rc1] Fix for Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom test ([release/7.0-rc1] Fix for Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom test #74181)
• [release/7.0-rc1] Disable matching constants for vectors that needs upper half to be save/restore ([release/7.0-rc1] Disable matching constants for vectors that needs upper half to be save/restore #74192)
• [release/7.0-rc1] Add runs for release/7.0* on community architectures ([release/7.0-rc1] Add runs for release/7.0* on community architectures #74239)
• Prevent awaiting promise that never resolves ([release/7.0-rc1] [WASM] Fix deadlock when instantiating pthread worker pool #74243)
• Remove AES and SubtleCrypto from WASM (Remove AES and SubtleCrypto from WASM #74165) ([release/7.0-rc1] Remove AES and SubtleCrypto from WASM #74246)
• [release/7.0-rc1] Disable failing runtime extra platforms tests ([release/7.0-rc1] Disable failing runtime extra platforms tests #74264)
• [release/7.0-rc1] Directory.CreateDirectory: create missing parents using default UnixFileMode. ([release/7.0-rc1] Directory.CreateDirectory: create missing parents using default UnixFileMode. #74277)
• [release/7.0-rc1] [wasm] Unwrap exception when calling entrypoint ([release/7.0-rc1] [wasm] Unwrap exception when calling entrypoint #74263)
• Update Xunit to 2.4.2 (Update Xunit to 2.4.2 #74296)
• [release/7.0] Update dependencies from dotnet/llvm-project dotnet/runtime-assets dotnet/roslyn-analyzers ([release/7.0] Update dependencies from dotnet/llvm-project dotnet/runtime-assets dotnet/roslyn-analyzers #74241)
• Update dependencies from https://github.com/dotnet/runtime-assets build 20220821.2 ([release/7.0] Update dependencies from dotnet/runtime-assets #74341)
• Remove assert from Http3Connection.SendAsync (Remove assert from Http3Connection.SendAsync #74348)

Author:	rzikm
Assignees:	-
Labels:	area-System.IO, new-api-needs-documentation
Milestone:	-

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Manual backport of #74348 to release/7.0

cc: @danmoseley

Customer Impact

None, this change affects only tests (Asserts don't run in Release configuration). We have seen an increased number of crashes on Debug runs on Alpine Linux where we recently enabled HTTP/3 test coverage (#74162). This PR serves to mainly de-noise CI reports.

Testing

Functional tests pass on CI, and the affected test was run many times in a tight loop on the affected configuration.

Risk

Low, test only change.

Author:	rzikm
Assignees:	rzikm
Labels:	area-System.Net.Http
Milestone:	-

[rzikm]

CI failure is unrelated (in HTTP2)

[danmoseley]

Lgtm, test stabilization that does not affect release

[carlossanlop]

Approved and signed off.
CI failure is unrelated.
Ready to merge.