[release/7.0-rc1] [wasm] Add new javascript API types #74222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
lewing and
pavelsavara
as code owners
dotnet-issue-labeler
bot
added
the
area-System.Runtime.InteropServices.JavaScript
label
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsBackport of #74166 to release/7.0-rc1 Customer ImpactNone. Only adding exported types to typescript definition. TestingManual, on sample. RiskNone. IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
@marek-safar @lewing @radical need someone to approve this, and also need a sign off. |
pavelsavara
approved these changes
Aug 22, 2022
lewing
approved these changes
Aug 22, 2022
|
Approved, signed off, and the CI passed. Ready to merge. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #74166 to release/7.0-rc1
/cc @maraf @yamachu
Customer Impact
Customers using typescript will be able to use new JS API.
Testing
Manual, on sample.
Risk
None, added exported types to typescript definition.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.