Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Add new javascript API types #74166

Merged
merged 1 commit into from
Aug 19, 2022
Merged

[wasm] Add new javascript API types #74166

merged 1 commit into from
Aug 19, 2022

Conversation

yamachu
Copy link
Contributor

@yamachu yamachu commented Aug 18, 2022

With #73785 , dotnet and exit are now public APIs with named exports.

When developing in TypeScript, importing dotnet did not work for type completion.
So I added those to d.ts .

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 18, 2022
@lewing lewing requested a review from maraf August 18, 2022 18:43
maraf
maraf approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

@maraf maraf added the arch-wasm WebAssembly architecture label Aug 19, 2022
@ghost
Copy link

ghost commented Aug 19, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

With #73785 , dotnet and exit are now public APIs with named exports.

When developing in TypeScript, importing dotnet did not work for type completion.
So I added those to d.ts .

Author: yamachu
Assignees: -
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, community-contribution
Milestone: -

@maraf maraf merged commit e23f543 into dotnet:main Aug 19, 2022
@maraf
Copy link
Member

maraf commented Aug 19, 2022

/backport to release/7.0-rc1

@github-actions
Copy link
Contributor

Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2887864418

@yamachu yamachu deleted the add-dotnet-exports-type branch August 19, 2022 07:41
@github-actions github-actions bot mentioned this pull request Aug 19, 2022
Merged
@maraf maraf mentioned this pull request Aug 19, 2022
Merged
@runfoapp runfoapp bot mentioned this pull request Aug 19, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yamachu @maraf