Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0][Android] Backport fix NetworkInterface.GetAllNetworkInterfaces #76565

Conversation

simonrozsival
Copy link
Member

@simonrozsival simonrozsival commented Oct 3, 2022

Backport of #76370 and #76541 to release/7.0

Fixes #75809
Fixes #76493
Fixes dotnet/android#6973

/cc @steveisok @akoeplinger

Customer impact

Several customers reported problems with the current implementation in #75809 and #76493

Testing

  • unit tests in CI
  • locally on physical device (Android API 31) and Android emulator (API level 21)

Risk

Low. The change is inspired by an existing implementation in Xamarin.Android.

simonrozsival and others added 2 commits October 3, 2022 21:55
* Revert "[Android] Port getifaddrs implementation from Xamarin.Android (dotnet#71943)"

This reverts commit 1de4a5c.

* Fix allocating memory block for interfaces and addresses on recent Android SDKs

* Detect loopback interface on Android

* Add comment with explanation

* Simplify the changes to be closer to the original code

* Fix build

* Fix typos

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>

* Improve comment

* Indent using spaces instead of tabs

* Remove check for ifaddrs.h

* Add ANDROID_GETIFADDRS_WORKAROUND

* Update comment

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
@simonrozsival simonrozsival added Servicing-consider Issue for next servicing release review os-android labels Oct 3, 2022
@simonrozsival simonrozsival added this to the 7.0.0 milestone Oct 3, 2022
@ghost
Copy link

ghost commented Oct 3, 2022

Tagging subscribers to 'arch-android': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #76370 and #76541 to release/7.0

/cc @steveisok @akoeplinger

Customer impact

Several customers reported problems with the current implementation in #75809 and #76493

Testing

  • unit tests in CI
  • locally on physical device (Android API 31) and Android emulator (API level 21)

Risk

Low. The change is inspired by an existing implementation in Xamarin.Android.

Author: simonrozsival
Assignees: -
Labels:

Servicing-consider, os-android

Milestone: 7.0.0

@ghost
Copy link

ghost commented Oct 3, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #76370 and #76541 to release/7.0

/cc @steveisok @akoeplinger

Customer impact

Several customers reported problems with the current implementation in #75809 and #76493

Testing

  • unit tests in CI
  • locally on physical device (Android API 31) and Android emulator (API level 21)

Risk

Low. The change is inspired by an existing implementation in Xamarin.Android.

Author: simonrozsival
Assignees: simonrozsival
Labels:

Servicing-consider, area-System.Net, os-android

Milestone: 7.0.0

@simonrozsival
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop
Copy link
Member

@simonrozsival if you haven't done so, please send an email to Tactics requesting approval.
@akoeplinger and/or @steveisok, please provide a code review sign-off.

@steveisok steveisok added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 3, 2022
Copy link
Member

@steveisok steveisok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by tactics over email

@simonrozsival
Copy link
Member Author

The failing tests are unrelated to this change

@carlossanlop carlossanlop merged commit 450b8f4 into dotnet:release/7.0 Oct 5, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants