[release/6.0][Android] Backport fix NetworkInterface.GetAllNetworkInterfaces #77260
+90
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Revert "[Android] Port getifaddrs implementation from Xamarin.Android (dotnet#71943)" This reverts commit 1de4a5c. * Fix allocating memory block for interfaces and addresses on recent Android SDKs * Detect loopback interface on Android * Add comment with explanation * Simplify the changes to be closer to the original code * Fix build * Fix typos Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> * Improve comment * Indent using spaces instead of tabs * Remove check for ifaddrs.h * Add ANDROID_GETIFADDRS_WORKAROUND * Update comment Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
…otnet#76541) * Bring back pal_ifaddrs * Update the header file
simonrozsival
added
Servicing-consider
ghost
assigned 
|
Tagging subscribers to 'arch-android': @steveisok, @akoeplinger Issue DetailsBackport of #76370 and #76541 to release/6.0 Customer impactSeveral customers reported problems with the current implementation in #75809 and #76493 Testing
RiskLow. The change is inspired by an existing implementation in Xamarin.Android. This change was also previously backported to
|
|
/azp run runtime-manual |
|
No pipelines are associated with this pull request. |
|
/azp list |
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Oct 20, 2022
rbhanda
added
Servicing-approved
|
@akoeplinger can you please provide a code review sign-off? |
akoeplinger
approved these changes
Oct 25, 2022
|
Failures are old and logs are gone. Need to rebase and re-run since there were several failures. Closing and reopening. |
|
CI failures unrelated:
Approved by Tactics. Signed off by code reviewer. No OOB package authoring changes needed. Ready to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #76370 and #76541 to release/6.0
Fixes #75809
Fixes #76493
Fixes dotnet/android#6973
/cc @steveisok @akoeplinger
Customer impact
Note: This change was also previously backported to
release/7.0(#76565). It was an oversight that it did not come back to release/6.0 as well.Several MAUI customers reported problems with the current implementation in #75809 and #76493
Testing
Risk
Low. The change is inspired by an existing implementation in Xamarin.Android.