Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable regions for AoT #76737

Merged
merged 1 commit into from
Oct 8, 2022
Merged

enable regions for AoT #76737

merged 1 commit into from
Oct 8, 2022

Conversation

Maoni0
Copy link
Member

@Maoni0 Maoni0 commented Oct 7, 2022

this fixes the last issue standing in the way of enabling regions for AoT. AoT could conservatively report addresses that land in the GC heap range but not in range that bookkeeping covers. so these need to filtered out.

@ghost
Copy link

ghost commented Oct 7, 2022

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

this fixes the last issue standing in the way of enabling regions for AoT. AoT could conservatively report addresses that land in the GC heap range but not in range that bookkeeping covers. so these need to filtered out.

Author: Maoni0
Assignees: -
Labels:

area-GC-coreclr

Milestone: -

@jkotas
Copy link
Member

jkotas commented Oct 7, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Maoni0
Copy link
Member Author

Maoni0 commented Oct 7, 2022

the "Libraries Build OSX x64 Release" check says

2022-10-07T15:14:51.2483434Z Report issues and find source on GitHub: https://github.com/dotnet/core
2022-10-07T15:14:51.2484869Z Use 'dotnet --help' to see available commands or visit: https://aka.ms/dotnet-cli
2022-10-07T15:14:51.2485798Z --------------------------------------------------------------------------------------
2022-10-07T15:14:51.6083451Z /__w/1/s/.dotnet/sdk/7.0.100-rc.1.22431.12/MSBuild.dll /nologo -maxcpucount /m -verbosity:m /v:minimal /bl:/__w/1/s/artifacts/log/Release/ToolsetRestore.binlog /clp:Summary /clp:ErrorsOnly;NoSummary /nr:false /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=true /p:__ToolsetLocationOutputFile=/__w/1/s/artifacts/toolset/8.0.0-beta.22503.1.txt /t:__WriteToolsetLocation /warnaserror /__w/1/s/artifacts/toolset/restore.proj
2022-10-07T15:14:55.6156195Z /__w/1/s/eng/common/tools.sh: line 474:   537 Segmentation fault      (core dumped) "$_InitializeBuildTool" "$@"
2022-10-07T15:14:55.6156986Z Build failed with exit code 139. Check errors above.

@jkotas do you know where I can get info on this seg fault? the other failure seems to be related to mono.

@jkotas
Copy link
Member

jkotas commented Oct 7, 2022

We do not save dumps for crashes that occur during the build. I have opened #76759 on this and restarted the leg.

Copy link
Member

@cshung cshung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Maoni0 Maoni0 merged commit cb6e5e7 into dotnet:main Oct 8, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants