Conservative GC reporting for suspended green threads #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ange but not in bookkeeping range
davidwrighton
approved these changes
Oct 7, 2022
cshung
force-pushed
the
public/green-threads-gc-reporting
branch
2 times, most recently
from
a2030f8 to
5f3160b
Compare
cshung
force-pushed
the
public/green-threads-gc-reporting
branch
from
5f3160b to
07dbe3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GC changes come from dotnet/runtime#76737 which is required for conservative reporting. Once we have that PR merged, we should take an FI instead to avoid unnecessary conflicts.
The green thread changes slightly extended the lifetime of the
SuspendedGreenThreadobject so that I can use it for GC reporting. The change simply loop through all of them and reported all the stack segments conservatively.In debug mode, the process terminates with an exit code
1073807370==0x4001000a, this is because we hit an assert here. I assume this will be handled as part of #2018