Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Update dependencies from dotnet/emsdk dotnet/arcade #78062

Merged

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 8, 2022

This pull request updates the following dependencies

From https://github.com/dotnet/emsdk

  • Subscription: 662e2218-ac3b-45e0-0adc-08d961c5a36b
  • Build: 20221108.3
  • Date Produced: November 8, 2022 7:35:11 PM UTC
  • Commit: 07c7b3da3b4b9d810fa24e1a115918c4efa9e924
  • Branch: refs/heads/release/6.0

From https://github.com/dotnet/arcade

  • Subscription: 36974d0f-1ebe-4d41-3a49-08d961c5a689
  • Build: 20221111.1
  • Date Produced: November 11, 2022 6:08:35 PM UTC
  • Commit: 0967701e5527a1be21d9473821077c3f4be7f9dc
  • Branch: refs/heads/release/6.0

…08.3

Microsoft.NET.Workload.Emscripten.Manifest-6.0.100 , Microsoft.NET.Workload.Emscripten.Manifest-6.0.300 , Microsoft.NET.Workload.Emscripten.Manifest-6.0.400
 From Version 6.0.11 -> To Version 6.0.12
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Nov 8, 2022
…108.2

Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 6.0.0-beta.22512.3 -> To Version 6.0.0-beta.22558.2
@dotnet-maestro dotnet-maestro bot changed the title [release/6.0] Update dependencies from dotnet/emsdk [release/6.0] Update dependencies from dotnet/emsdk dotnet/arcade Nov 8, 2022
@carlossanlop
Copy link
Member

Requeuing the failed legs. They got hit by unrelated infra failures related to the docker containers.

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the CI re-run, all the infra problems related to docker went away, but an "unknown banana RID" failure was uncovered: #78197

I don't think the RID problem was caused by the emsdk and arcade dependencies. So I think this is good to merge now. @mmitche or @jkoritzinsky do you have any objections?

Comment on lines -66 to -70
runtimeOsArgs=
if [ '${{ parameters.platform.runtimeOS }}' != '' ]; then
runtimeOsArgs='/p:RuntimeOS=${{ parameters.platform.runtimeOS }}'
fi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlossanlop this is likely the change that causes the source build leg to fail

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So are you suggesting we revert this code removal?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responded offline. I'm just saying that this PR could be related to the Banana Source Build break, and you want to hold off merging it until you understand the break. A binlog should tell.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this can't be reverted. It will get moved in a subsequent PR. This is a common script file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change: 552fcf0 is the issue.

Basically, this change to the template must go into arcade.

/cc @ayakael

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for now a PR can be opened in arcade, and this change reverted in this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the source-build.yml change in this PR to unblock it.

@ayakael please submit your template change to the arcade repo directly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy, it's here: dotnet/arcade#11604

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, the maestro bot brought these removals back, causing the banana RID failure happened in the last run.
I'll merge the PR with that known failure, and will submit a separate PR to get the lines restored. I don't want to restart the CI just for this.

@carlossanlop carlossanlop added the blocked Issue/PR is blocked on something - see comments label Nov 11, 2022
…108.7

Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 6.0.0-beta.22512.3 -> To Version 6.0.0-beta.22558.7
@radical
Copy link
Member

radical commented Nov 14, 2022

Wasm runtime tests failure:

/datadisks/disk1/work/AF330959/p/wasm-test-runner/WasmTestRunner.proj :

error MSB4242: SDK Resolver Failure: "The SDK resolver "NuGetSdkResolver" failed while attempting to resolve the SDK "Microsoft.Build.NoTargets/1.0.53". Exception:

"System.IO.IOException: The system cannot open the device or file specified. : 'NuGet-Migrations'
  at System.Threading.Mutex.CreateMutexCore(Boolean initiallyOwned, String name, Boolean& createdNew)
  at System.Threading.Mutex..ctor(Boolean initiallyOwned, String name)
  at NuGet.Common.Migrations.MigrationRunner.Run()
  at Microsoft.Build.NuGetSdkResolver.NuGetSdkResolver.Resolve(SdkReference sdkReference, SdkResolverContext resolverContext, SdkResultFactory factory)
  at Microsoft.Build.BackEnd.SdkResolution.SdkResolverService.ResolveSdk(Int32 submissionId, SdkReference sdk, LoggingContext loggingContext, ElementLocation sdkReferenceLocation, String solutionPath, String projectPath, Boolean interactive, Boolean isRunningInVisualStudio)""

Does this look like a bug in the nuget migrations code?
cc @kartheekp-ms @stephentoub

…110.1

Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 6.0.0-beta.22512.3 -> To Version 6.0.0-beta.22560.1
@kartheekp-ms
Copy link

Wasm runtime tests failure:

/datadisks/disk1/work/AF330959/p/wasm-test-runner/WasmTestRunner.proj :

error MSB4242: SDK Resolver Failure: "The SDK resolver "NuGetSdkResolver" failed while attempting to resolve the SDK "Microsoft.Build.NoTargets/1.0.53". Exception:

"System.IO.IOException: The system cannot open the device or file specified. : 'NuGet-Migrations'
  at System.Threading.Mutex.CreateMutexCore(Boolean initiallyOwned, String name, Boolean& createdNew)
  at System.Threading.Mutex..ctor(Boolean initiallyOwned, String name)
  at NuGet.Common.Migrations.MigrationRunner.Run()
  at Microsoft.Build.NuGetSdkResolver.NuGetSdkResolver.Resolve(SdkReference sdkReference, SdkResolverContext resolverContext, SdkResultFactory factory)
  at Microsoft.Build.BackEnd.SdkResolution.SdkResolverService.ResolveSdk(Int32 submissionId, SdkReference sdk, LoggingContext loggingContext, ElementLocation sdkReferenceLocation, String solutionPath, String projectPath, Boolean interactive, Boolean isRunningInVisualStudio)""

Does this look like a bug in the nuget migrations code? cc @kartheekp-ms @stephentoub

@radical - May be this error has the same root cause mentioned in #36823 which was created as a follow-up for PowerShell/PSReadLine#1464.

…111.1

Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 6.0.0-beta.22512.3 -> To Version 6.0.0-beta.22561.1
@radical
Copy link
Member

radical commented Nov 14, 2022

Does this look like a bug in the nuget migrations code? cc @kartheekp-ms @stephentoub

@radical - May be this error has the same root cause mentioned in #36823 which was created as a follow-up for PowerShell/PSReadLine#1464.

Shouldn't it happen on all the other helix work items that are running these runtime tests? Only 2 out of the 35 items failed with this.

I'm re-running the tests to see if it fails again. I'll remove the use of the package, which should hopefully mitigate the issue for our specific case.

@radical
Copy link
Member

radical commented Nov 14, 2022

I'm re-running the tests to see if it fails again. I'll remove the use of the package, which should hopefully mitigate the issue for our specific case.

The tests passed this time. I'll backport #75939 here.

This will also avoid intermittent failures like #75391
# Conflicts:
#	src/tests/Common/wasm-test-runner/WasmTestRunner.proj
@carlossanlop
Copy link
Member

The banana RID commit I manually pushed got reverted by the bot. I don't want to restart the CI just for that failure so I'll submit that fix again separately.
For the rest of the failures, they don't seem related to this change: #64153, #78360, #78361.
Merging now.

@carlossanlop carlossanlop merged commit 6d2a000 into release/6.0 Nov 15, 2022
@carlossanlop carlossanlop deleted the darc-release/6.0-02b0394f-aa74-4d7d-9f9e-ac6f6ae0de35 branch November 15, 2022 04:33
@ghost ghost locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow blocked Issue/PR is blocked on something - see comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants