Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Mono musl support (backport #76500) #78274

Closed

Conversation

ayakael
Copy link
Contributor

@ayakael ayakael commented Nov 12, 2022

Backport of #76500 to release/6.0

/cc: @am11

Customer Impact

Permits building of mono-flavored runtme on mono-based systems like Alpine Linux. Without this patch, build fails and s390x platforms. This would presumably cover all other mono-supported platforms as well.

Testing

  • unit tests in ci
  • source-build build within Alpine environment passes

Risk

Low as most of the modifications only expresses themselves when musl-based system is detected.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 12, 2022
@ayakael ayakael changed the title Mono musl support (backport #76500) [release/6.0] Mono musl support (backport #76500) Nov 12, 2022
@ghost
Copy link

ghost commented Nov 12, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #76500 to release/6.0

Customer Impact

Permits building of mono-flavored runtme on mono-based systems like Alpine Linux. Without this patch, build fails and s390x platforms. This would presumably cover all other mono-supported platforms as well.

Testing

  • unit tests in ci
  • source-build build within Alpine environment passes

Risk

Low as most of the modifications only expresses themselves when musl-based system is detected.

Author: ayakael
Assignees: -
Labels:

area-Infrastructure-mono, community-contribution

Milestone: -

@radical
Copy link
Member

radical commented Nov 15, 2022

WasmBuildTests on this should pass after #78062, which fixes the nuget source for `Microsoft.NET.Workload.Emscripten.Manifest-6.0.400.

@carlossanlop
Copy link
Member

WasmBuildTests on this should pass after #78062, which fixes the nuget source for `Microsoft.NET.Workload.Emscripten.Manifest-6.0.400.

This PR touches some native code. This might have to go through Tactics. Do we need this in 7.0.1? Today is the deadline to merge backports that will go into the December release, but the day is almost over to request an approval.

@akoeplinger
Copy link
Member

Let's please focus on #76500 first before creating 6.0/7.0 backports. We can do the backports once the main change is in. Closing this in the meantime, thanks 👍

@ghost ghost locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-mono community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants