[android][ios] Add LibraryBuilder task to support aot library mode #81919

steveisok · 2023-02-09T22:04:29Z

This change adds a build task to generate a self-contained shared or static library when using the aot compiler and will only export symbols for methods decorated with UnmanagedCallersOnly attributes (similar to NativeAOT).

For android, there is full testing integration that can be triggered by supplying /p:NativeLib=shared|static. iOS will come at a later date as it is a bit more complex trying to generate a framework project.

Contributes to #79377

…y on osx

… still path issues in the Xcode class

ghost · 2023-02-09T22:04:47Z

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This change adds a build task to generate a self-contained shared or static library when using the aot compiler and will only export symbols for methods decorated with UnmanagedCallersOnly attributes (similar to NativeAOT).

For android, there is full testing integration that can be triggered by supplying /p:NativeLib=shared|static. iOS will come at a later date as it is a bit more complex trying to generate a framework project.

Contributes to #79377

Author:	steveisok
Assignees:	steveisok
Labels:	`area-Infrastructure-mono`
Milestone:	-

src/mono/msbuild/common/LibraryBuilder.props

src/mono/msbuild/android/build/AndroidApp.targets

src/tests/FunctionalTests/Android/Device_Emulator/AOT_LLVM/Program.cs

src/tests/FunctionalTests/iOS/Device/AOT-LLVM/Program.cs

src/tasks/TestExclusionListTasks/TestExclusionListTasks.csproj

src/mono/msbuild/android/build/AndroidApp.targets

src/tasks/LibraryBuilder/LibraryBuilder.cs

src/tasks/AppleAppBuilder/Templates/CMakeLists.txt.template

src/tasks/AppleAppBuilder/Xcode.cs

azure-pipelines · 2023-03-01T02:29:16Z

Azure Pipelines successfully started running 1 pipeline(s).

steveisok · 2023-03-01T15:17:07Z

@akoeplinger @mdh1418 please give this another pass when you have a moment.

src/mono/msbuild/common/LibraryBuilder.targets

src/tests/FunctionalTests/Android/Device_Emulator/AOT_LLVM/Program.cs

steveisok · 2023-03-01T19:39:44Z

/azp run runtime-android

azure-pipelines · 2023-03-01T19:39:53Z

Azure Pipelines successfully started running 1 pipeline(s).

…butes. Additional cleanup.

src/mono/msbuild/android/build/AndroidApp.targets

akoeplinger · 2023-03-06T14:40:04Z

src/mono/msbuild/android/build/AndroidApp.targets

+    <ItemGroup Condition="'$(_IsLibraryMode)' == 'true'">
+      <DirectPInvokes Include="libSystem.Native" />
+      <DirectPInvokes Include="libSystem.IO.Compression.Native" />
+      <DirectPInvokes Include="libSystem.Security.Cryptography.Native.Android" />


this is missing libSystem.Net.Security.Native and libSystem.Security.Cryptography.Native (for Linux Bionic) and libSystem.Globalization.Native (for Filip's ICU PR).

I wonder if we should generate this list based on the .a files instead of hardcoding.

I'm ok with addressing this in a follow-up PR.

This will be addressed in a follow up.

akoeplinger · 2023-03-06T14:41:28Z

src/mono/msbuild/android/build/AndroidApp.targets

        <Output TaskParameter="CompiledAssemblies" ItemName="_AndroidAssembliesInternal" />
    </MonoAOTCompiler>

    <ItemGroup>
      <_AndroidAssembliesInternal Include="@(_AOT_InternalForceInterpretAssemblies)" />
+      <AppAssembliesInternal Include="@(_AndroidAssembliesInternal)" />


this is still unresolved

src/mono/msbuild/apple/build/AppleApp.targets

...unctionalTests/Android/Device_Emulator/AOT_LLVM/Android.Device_Emulator.Aot_Llvm.Test.csproj

steveisok · 2023-03-06T19:42:18Z

/azp run runtime-android

azure-pipelines · 2023-03-06T19:42:28Z

Azure Pipelines successfully started running 1 pipeline(s).

steveisok · 2023-03-06T21:52:42Z

Failure is known build error #80619

dotnet#81919 introduced a regression where the gss framework was omitted from the sample build. This change adds it back in. Fixes dotnet/performance#2924

#81919 introduced a regression where the gss framework was omitted from the sample build. This change adds it back in. Fixes dotnet/performance#2924

Steve Pfister added 13 commits January 11, 2023 09:17

Apple side of the library builder

1d8483b

Embed framework through cmake on iOS. Add android fragments

6cc724f

Android library build

bbf6992

Bring back android exports

0055975

Fix android library build by getting rid of force_load as that is onl…

76cdbe4

…y on osx

Merge remote-tracking branch 'upstream/main' into lib-builder-mobile

9caea1f

Android builds library in separate cmake. iOS does too, but there are…

9c3d805

… still path issues in the Xcode class

Add ability to pass in library projects to the main app

37fde1a

Clean up Android and scale back iOS to just building the library.

e3d1fd4

Merge remote-tracking branch 'upstream/main' into lib-builder-mobile

3911d2c

Move symbol table stripping to its own method

9bb0dd9

Revert aotcompiler.c workaround

4ed46bf

Condition some of the library builder specific items

fde2bda

steveisok requested review from radical and marek-safar as code owners February 9, 2023 22:04

ghost assigned steveisok Feb 9, 2023

dotnet-issue-labeler bot added the area-Infrastructure-mono label Feb 9, 2023

steveisok requested review from akoeplinger and mdh1418 February 9, 2023 22:04

steveisok requested a review from lateralusX February 9, 2023 22:04

steveisok mentioned this pull request Feb 9, 2023

[mono] Add support for library mode in the aot compiler #79377

Closed

9 tasks

Cleanup

d6fd785

steveisok force-pushed the lib-builder-mobile branch from 1e99eb2 to d6fd785 Compare February 10, 2023 00:10

Add library builder tasks as a correlation payload.

cde3f9d

steveisok force-pushed the lib-builder-mobile branch from 8f86b1d to 2b0f2ac Compare February 10, 2023 21:06

Remove unnecessary librarybuilder props import

6ba6aa9

steveisok force-pushed the lib-builder-mobile branch from 2b0f2ac to 6ba6aa9 Compare February 10, 2023 22:22

build-analysis bot mentioned this pull request Feb 11, 2023

Roslyn source generator crash on mono/linux/arm64 #81123

Closed

mdh1418 reviewed Feb 11, 2023

View reviewed changes

build-analysis bot mentioned this pull request Mar 1, 2023

Tracking issue for CI build timeouts #76454

Closed

This was referenced Mar 1, 2023

Test failure: System.Security.Cryptography.X509Certificates.Tests.CertificateCreation.CertificateRequestChainTests/CreateChain_Hybrid #25979

Closed

System.Security.Cryptography.X509Certificates.Tests.ChainTests.BuildInvalidSignatureTwice failure #65448

Closed

mdh1418 reviewed Mar 1, 2023

View reviewed changes

src/mono/msbuild/common/LibraryBuilder.targets Outdated Show resolved Hide resolved

src/tests/FunctionalTests/Android/Device_Emulator/AOT_LLVM/Program.cs Show resolved Hide resolved

Steve Pfister added 2 commits March 1, 2023 14:04

PR feedback. Add test UnmanagedCallersOnly back in

c99889b

Remove autoinit.c as it will come back in a follow up

223cf3a

This was referenced Mar 1, 2023

System.Security.Cryptography.X509Certificates.Tests.ChainTests.BuildInvalidSignatureTwice failure #82837

Open

Some System.Buffers.Binary.Tests.ReverseEndiannessUnitTests tests broken on main #82868

Closed

Generate list of assemblies that contained unmanagedcallersonly attri…

e641c28

…butes. Additional cleanup.

akoeplinger approved these changes Mar 6, 2023

View reviewed changes

Steve Pfister added 3 commits March 6, 2023 14:40

More feedback

6a23439

Merge remote-tracking branch 'upstream/main' into lib-builder-mobile

e272bb0

Ignore CA1850 in the library builder

f30804d

steveisok merged commit 88318ed into dotnet:main Mar 6, 2023

build-analysis bot mentioned this pull request Mar 6, 2023

IOException running NuGet-Migrations during tests in dotnet CLI first run #80619

Closed

steveisok deleted the lib-builder-mobile branch March 6, 2023 22:52

mdh1418 mentioned this pull request Mar 8, 2023

[tasks] Add auto runtime initialization template to LibraryBuilder #83050

Merged

steveisok mentioned this pull request Mar 9, 2023

[main][runtime] iOS app builds are failing dotnet/performance#2924

Closed

steveisok mentioned this pull request Mar 9, 2023

[iOS] Add gss framework back into sample linker args #83182

Merged

steveisok added a commit that referenced this pull request Mar 9, 2023

[iOS] Add gss framework back into sample linker args (#83182)

a92ed6e

#81919 introduced a regression where the gss framework was omitted from the sample build. This change adds it back in. Fixes dotnet/performance#2924

mdh1418 mentioned this pull request Apr 3, 2023

[mono][tasks] Extract EmitWasmBundle into generic EmitBundle task and enable bundling in mono self-contained library #84191

Merged

ghost locked as resolved and limited conversation to collaborators Apr 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[android][ios] Add LibraryBuilder task to support aot library mode #81919

[android][ios] Add LibraryBuilder task to support aot library mode #81919

steveisok commented Feb 9, 2023

ghost commented Feb 9, 2023

azure-pipelines bot commented Mar 1, 2023

steveisok commented Mar 1, 2023

steveisok commented Mar 1, 2023

azure-pipelines bot commented Mar 1, 2023

akoeplinger Mar 6, 2023

steveisok Mar 6, 2023

akoeplinger Mar 6, 2023

steveisok commented Mar 6, 2023

azure-pipelines bot commented Mar 6, 2023

steveisok commented Mar 6, 2023

[android][ios] Add LibraryBuilder task to support aot library mode #81919

[android][ios] Add LibraryBuilder task to support aot library mode #81919

Conversation

steveisok commented Feb 9, 2023

ghost commented Feb 9, 2023

azure-pipelines bot commented Mar 1, 2023

steveisok commented Mar 1, 2023

steveisok commented Mar 1, 2023

azure-pipelines bot commented Mar 1, 2023

akoeplinger Mar 6, 2023

Choose a reason for hiding this comment

steveisok Mar 6, 2023

Choose a reason for hiding this comment

akoeplinger Mar 6, 2023

Choose a reason for hiding this comment

steveisok commented Mar 6, 2023

azure-pipelines bot commented Mar 6, 2023

steveisok commented Mar 6, 2023