Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Add gss framework back into sample linker args #83182

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

steveisok
Copy link
Member

#81919 introduced a regression where the gss framework was omitted from the sample build. This change adds it back in.

Fixes dotnet/performance#2924

dotnet#81919 introduced a regression where the gss framework was omitted from the sample build. This change adds it back in.

Fixes dotnet/performance#2924
@ghost
Copy link

ghost commented Mar 9, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

#81919 introduced a regression where the gss framework was omitted from the sample build. This change adds it back in.

Fixes dotnet/performance#2924

Author: steveisok
Assignees: steveisok
Labels:

area-Infrastructure-mono

Milestone: -

Copy link
Member

@ivanpovazan ivanpovazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@steveisok
Copy link
Member Author

Wasm failure was reported as a known build error in #83214.

The rest are previously known build failures.

@steveisok steveisok merged commit a92ed6e into dotnet:main Mar 9, 2023
@steveisok steveisok deleted the fix-gss-link-spot branch March 9, 2023 16:28
@ghost ghost locked as resolved and limited conversation to collaborators Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[main][runtime] iOS app builds are failing
3 participants