Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lowering for get_One, get_AllBitSet, createScalar(), createScalarUnsafe(). #83402

Merged
merged 3 commits into from
Mar 15, 2023
Merged

Add lowering for get_One, get_AllBitSet, createScalar(), createScalarUnsafe(). #83402

merged 3 commits into from
Mar 15, 2023

Conversation

DeepakRajendrakumaran
Copy link
Contributor

@DeepakRajendrakumaran DeepakRajendrakumaran commented Mar 14, 2023 •
edited
Loading

This makes progress towards #80814. Also helps with #83354

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 14, 2023
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Mar 14, 2023
@ghost
Copy link

ghost commented Mar 14, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

This makes progress towards #80814 and #73604. Also helps with #83354

Author: DeepakRajendrakumaran
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@DeepakRajendrakumaran
Copy link
Contributor Author

DeepakRajendrakumaran commented Mar 14, 2023 •
edited
Loading

@tannergooding @BruceForstall @anthonycanino

Had to add a new instruction VPTERNLOG since cmp instruction previously used to set all bits would write result to k register. And that is not ideal. Everything else should be straightforward

@DeepakRajendrakumaran DeepakRajendrakumaran marked this pull request as draft March 14, 2023 17:29
@build-analysis build-analysis bot mentioned this pull request Mar 14, 2023
Closed
@DeepakRajendrakumaran DeepakRajendrakumaran force-pushed the vector512API_2 branch 2 times, most recently from 42dbaaa to 6096524 Compare March 14, 2023 22:12
@DeepakRajendrakumaran DeepakRajendrakumaran changed the title Add lowering for get_One, and get_AllBitSet. Add lowering for get_One, get_AllBitSet, createScalar(), createScalarUnsafe(). Mar 14, 2023
@DeepakRajendrakumaran DeepakRajendrakumaran marked this pull request as ready for review March 14, 2023 22:38
@build-analysis build-analysis bot mentioned this pull request Mar 15, 2023
Closed
@tannergooding
Copy link
Member

CC. @dotnet/jit-contrib, @dotnet/avx512-contrib for secondary review/sign-off

Failures are #83298 which has a revert PR up #83412

Tests covering the relevant changes did run and pass, despite the timeouts (can see that in the console log by searching for Vector512_1.Program.AllBitsSet and related entries).

@tannergooding tannergooding mentioned this pull request Mar 15, 2023
Merged
@tannergooding tannergooding merged commit 41cb2d3 into dotnet:main Mar 15, 2023
@BruceForstall BruceForstall added the avx512 Related to the AVX-512 architecture label Mar 27, 2023
@JulieLeeMSFT JulieLeeMSFT mentioned this pull request Apr 4, 2023
Open
3 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tannergooding tannergooding tannergooding approved these changes

@EgorBo EgorBo EgorBo approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI avx512 Related to the AVX-512 architecture community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DeepakRajendrakumaran @tannergooding @EgorBo @BruceForstall