Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linker flags to add fixup data to PDBs (#58417) #84099

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Add linker flags to add fixup data to PDBs (#58417) #84099

merged 1 commit into from
Mar 31, 2023

Conversation

agocke
Copy link
Member

@agocke agocke commented Mar 29, 2023

Fixup data can assist native debugging tools in providing more accurate data

(cherry picked from commit 4c814fa)

@agocke
Add linker flags to add fixup data to PDBs (dotnet#58417)
cffdb3a 
Fixup data can assist native debugging tools in providing more accurate data

(cherry picked from commit 4c814fa)
@ghost ghost assigned agocke Mar 29, 2023
@ghost
Copy link

ghost commented Mar 29, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixup data can assist native debugging tools in providing more accurate data

(cherry picked from commit 4c814fa)

Author: agocke
Assignees: agocke
Labels:

area-Infrastructure-coreclr
Milestone: -

@agocke
Copy link
Member Author

agocke commented Mar 29, 2023

I forgot to port this one to main, so it got stuck in 6.0.

@agocke agocke requested a review from a team March 29, 2023 22:32
@build-analysis build-analysis bot mentioned this pull request Mar 30, 2023
Closed
@agocke agocke merged commit 5eeb91f into dotnet:main Mar 31, 2023
@agocke agocke deleted the port-debugtype branch March 31, 2023 23:04
@EgorBo EgorBo mentioned this pull request Apr 4, 2023
Open
@agocke
Copy link
Member Author

agocke commented Apr 4, 2023 •
edited
Loading

/backport to release/7.0

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

Started backporting to 7.0: https://github.com/dotnet/runtime/actions/runs/4612218884

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

@agocke an error occurred while backporting to 7.0, please check the run log for details!

The process '/usr/bin/git' failed with exit code 1

@carlossanlop
Copy link
Member

carlossanlop commented Apr 4, 2023 •
edited
Loading

@agocke please backport to release/7.0-staging.

@carlossanlop
Copy link
Member

BTW the bot ignored your ninja edit from 7.0 to release/7.0 😄

@agocke
Copy link
Member Author

agocke commented Apr 5, 2023

/backport to release/7.0-staging

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

Started backporting to release/7.0-staging: https://github.com/dotnet/runtime/actions/runs/4620950126

@github-actions github-actions bot mentioned this pull request Apr 5, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hoyosjs hoyosjs hoyosjs approved these changes

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

Assignees

@agocke agocke

Labels
area-Infrastructure-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agocke @carlossanlop @jkoritzinsky @hoyosjs