Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/7.0-staging] Add linker flags to add fixup data to PDBs (#58417) #84358

Merged
merged 1 commit into from
May 15, 2023
Merged

[release/7.0-staging] Add linker flags to add fixup data to PDBs (#58417) #84358

merged 1 commit into from
May 15, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 5, 2023 •
edited by agocke
Loading

Backport of #84099 to release/7.0-staging

/cc @agocke

Customer Impact

This is a cleanup PR. I made this change for 6.0, but forgot to put it into 7.0, which was main at the time. That means that there's an appeared regression, such that the linker changes are in 6.0 and not 7.0. This can cause tooling which expects the data to become confused.

Testing

Existing CI.

Risk

Very low. Change already exists in main and in 6.0.

@agocke
Add linker flags to add fixup data to PDBs (#58417)
219daea 
Fixup data can assist native debugging tools in providing more accurate data

(cherry picked from commit 4c814fa)
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 5, 2023
@carlossanlop
Copy link
Member

@agocke today's code complete for the May Servicing Release. Do you intend to get this included in that release?

@agocke
Copy link
Member

agocke commented Apr 10, 2023

Probably won't get it in for May. That's fine.

@jeffhandley jeffhandley added area-Infrastructure-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 11, 2023
@ghost
Copy link

ghost commented Apr 11, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #84099 to release/7.0-staging

/cc @agocke

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-coreclr
Milestone: -

@carlossanlop
Copy link
Member

@agocke how's this looking for June?

@agocke agocke added the Servicing-consider Issue for next servicing release review label May 9, 2023
jeffschwMSFT
jeffschwMSFT approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we can treat this as tell mode. once we have code reviewers, let's merge.

@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels May 9, 2023
@jeffschwMSFT jeffschwMSFT added this to the 7.0.7 milestone May 9, 2023
@agocke agocke requested a review from jkoritzinsky May 9, 2023 17:07
jkoritzinsky
jkoritzinsky approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlossanlop
Copy link
Member

Today is Code Complete for the June Release. @agocke if this is good to merge, please do the honors and smash that squash&merge button.

@agocke agocke merged commit bf7c094 into release/7.0-staging May 15, 2023
@agocke agocke deleted the backport/pr-84099-to-release/7.0-staging branch May 15, 2023 21:29
@radical radical mentioned this pull request Jun 15, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hoyosjs hoyosjs hoyosjs approved these changes

@jeffschwMSFT jeffschwMSFT jeffschwMSFT approved these changes

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

Assignees
No one assigned
Labels
area-Infrastructure-coreclr Servicing-approved Approved for servicing release
Projects
None yet
Milestone
7.0.7
Development

Successfully merging this pull request may close these issues.
6 participants
@carlossanlop @agocke @jkoritzinsky @jeffschwMSFT @hoyosjs @jeffhandley