Fix an SSA bug from the ASG refactoring
#86108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recording PHIs from analyzable stores is a correctness requirement.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThe SSA renaming code was changed in an incompatible way s.t. memory stores in protected blocks were no longer considered to induce PHIs in the corresponding handlers.
|
SingleAccretion
commented
May 11, 2023
| @@ -1114,7 +1114,7 @@ void SsaBuilder::BlockRenameVariables(BasicBlock* block) | |||
| { | |||
| for (GenTree* const tree : stmt->TreeList()) | |||
| { | |||
| if (tree->OperIsSsaDef()) | |||
| if (tree->OperIsStore() || tree->OperIs(GT_CALL)) | |||
There was a problem hiding this comment.
In actuality the same problem exists for un-analyzable stores as well. But that is a pre-existing issue.
Reproduction
[MethodImpl(MethodImplOptions.NoInlining | MethodImplOptions.AggressiveOptimization)]
public static bool Problem()
{
[MethodImpl(MethodImplOptions.NoInlining)]
static void Throw()
{
_intStatic = 1;
throw new Exception();
}
_intStatic = 2;
try
{
Throw();
_intStatic = 2;
}
catch (Exception)
{
if (_intStatic == 2)
{
return true;
}
}
return false;
}Filed #86112 for this.
AndyAyersMS
approved these changes
May 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SSA renaming code was changed in an incompatible way s.t. memory stores in protected blocks were no longer considered to induce PHIs in the corresponding handlers.