-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the test build error #86176
Fix the test build error #86176
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
@dotnet/jit-contrib |
I am surprised the CI for original PR pass. @markples - do you know why? |
A PR race condition - #86108 was merged after the CI run but before merge. It looks like the test is failing in outerloop/CG2 - can we disable it everywhere against #86112 (don't want to disable only on CG2 because it'll fail on NAOT and under collectible assemblies)? (I was about to submit a change for that) |
If two PRs are open at the same time, they each test without the other. (I.e., we don't serialize testing/merging.) I updated the .cs file to match. I plan on strengthening the checks in various ways to avoid mistakes, but also the copy/paste practice of writing tests is vulnerable while the merging process is going on, which will pass. |
Got it. What was the other PR you are referring to? |
Mine was open for a while because I hadn't gone through the "extra" test results and probably should have checked the history before merging. I just checked and there don't seem to be any other new tests in any of the directories that I just put into merged groups. |
#86108 added a test that was failing the merge test checks.
https://dev.azure.com/dnceng-public/public/_build/results?buildId=272279&view=logs&j=c92f2c34-43c3-5f9c-356c-2e863ce9eb4e&t=1bb8c7f3-fff6-5069-c97d-796b6a1413a0&l=3934
@markples