[OSX] HybridGlobalization Implement casing functions #87919
Conversation
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
||
| typedef enum | ||
| { | ||
| ERROR_SUCCESS = 0, |
There was a problem hiding this comment.
Nit: ERROR_NONE or SUCCESS or NO_ERROR
There was a problem hiding this comment.
I noticed that we use quite often ERROR_SUCCESS , like https://github.com/dotnet/runtime/blob/main/src/native/libs/System.Native/pal_networking.c#L709
https://github.com/dotnet/runtime/blob/main/src/coreclr/pal/src/init/pal.cpp#L787 and many other places.
There was a problem hiding this comment.
ERROR_SUCCESS is a name from Windows SDK: https://learn.microsoft.com/en-us/windows/win32/debug/system-error-codes--0-499- . It is not a great name. We use it when we are on Windows or when we are trying to emulate Windows. It is not the case here.
There was a problem hiding this comment.
I see, will update it, thanks!
There was a problem hiding this comment.
We have globalization error codes defined in
. You may consider reusing and amending this definition.
ghost
added
the
needs-author-action
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
removed
the
needs-author-action
There was a problem hiding this comment.
Looks good if the exception throwing will be solved in #88180.
Implements a chunk of apple native-api based globalization.
Old, icu-based private API:
GlobalizationNative_ChangeCase
GlobalizationNative_ChangeCaseInvariant
New, non-icu private API:
GlobalizationNative_ChangeCaseNative
GlobalizationNative_ChangeCaseInvariantNative
Contributes to #80689
cc @SamMonoRT