-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows-x86 release MSBuild_CMake is failing #88172
Comments
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsBuild InformationBuild: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=324484 Error MessageFill the error message using step by step known issues guidance. {
"ErrorMessage": "Failed to generate native component build project",
"ErrorPattern": "Failed to generate native component build project",
"BuildRetry": false,
"ExcludeConsoleLog": false
}
|
This already affected 18 PRs - the actual interesting part of the error seems to be:
The only interesting thing I see is 17.5.5 -> 17.6 VS move. This might entail a bump in the CMake version since there was no arcade upgrade. |
This is the same as #88116 |
Tagging subscribers to this area: @hoyosjs Issue DetailsBuild InformationBuild: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=324484 Error MessageFill the error message using step by step known issues guidance. {
"ErrorMessage": "",
"ErrorPattern": " The TargetFramework value '' was not recognized .*ijw\\.vcxproj]",
"BuildRetry": false,
"ExcludeConsoleLog": false
} Known issue validationBuild: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=324484 Report
Summary
|
cc @jkoritzinsky in case you are aware. The 17.6 cmake is 3.22.6 |
I guess the C++/CLI support in MSBuild might have had a change that broke the build? I'll take a look. |
I can't repro this locally, so this might be an issue only with 17.6... |
It looks like the issue is with CMake 3.26. CMake 3.26 added support for I wasn't reproing it locally as I only have CMake 3.24 on my local machine. |
@dotnet/dnceng qq - In helix.dot.net I see windows-cmake 3.22.6, but if I create a VM in repro vms I only see 3.26.0-msvc3. Does the table get generated per deployment? And does it track all assets - even if MSI installed by VS? I was checking the BI report and couldn't find the assets, but I don't know if I just missed it. |
@hoyosjs we install "native-tools": {
"cmake": "3.22.6"
} or (much better because you won't need to change anything if the minor version changes): "native-tools": {
"cmake": "latest"
} note see https://github.com/dotnet/arcade/blob/main/Documentation/NativeToolsOnMachine.md for more information it's likely installing VS w/ the |
@dougbu It would be better to depend on cmake that comes with VS and stop installing the one from cmake.org site. |
I was not part of those discussions. Here are the reasons why I think it makes sense to use cmake that comes with VS on Windows:
|
Reopening and updating labels to continue the discussion about the cmake tool itself. |
please open an issue in dotnet/dnceng if your team (a core |
/btw I'm seeing a lot of hits for |
The matching string was changed multiple times by different people. This log was matched using older matching string. |
Done: dotnet/dnceng#322 |
Build Information
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=324484
Build error leg or test failing: Build / windows-x86 release MSBuild_CMake / Build product
Pull request: #88151
Error Message
Fill the error message using step by step known issues guidance.
Known issue validation
Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=324484
Error message validated:
MSBuild_CMake
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 6/29/2023 3:44:45 PM UTC
Report
Summary
The text was updated successfully, but these errors were encountered: