Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TLS resume with HttpClientHandler on Linux #88214

Merged
merged 6 commits into from
Jul 6, 2023
Merged

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Jun 29, 2023

fixes #75434
contributes to #75545

The existing code prevents TLS resume on Linux when HttpClientHandler is used (works fine if SocketsHttpHandler is used directly)

I updated test loopback server with CertificateContext. I was debating if we should add while ssl options but decided not to as there is currently no other use for it.

@wfurt wfurt requested a review from a team June 29, 2023 20:52
@wfurt wfurt self-assigned this Jun 29, 2023
@ghost
Copy link

ghost commented Jun 29, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

fixes #75434
contributes to #75545

The existing code prevents TLS resume on Linux when HttpClientHandler is used (works fine if SocketsHttpHandler us used directly)

I updated test loopback server with CertificateContext. I was debating if we should add while ssl options but decided not to as there is currently no other use for it.

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Http

Milestone: -

Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@karelz karelz added this to the 8.0.0 milestone Jul 3, 2023
@wfurt
Copy link
Member Author

wfurt commented Jul 6, 2023

all the failures are known according to `build analyses.

@wfurt wfurt merged commit 0224f86 into dotnet:main Jul 6, 2023
@wfurt wfurt deleted the httpResume branch July 6, 2023 19:42
@ghost ghost locked as resolved and limited conversation to collaborators Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpClientHandler always set LocalCertificateSelectionCallback delegate in SslOptions
3 participants