Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies for dotnet/optimization to build 20230626.3 #88200

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Update dependencies for dotnet/optimization to build 20230626.3 #88200

merged 1 commit into from
Jun 29, 2023

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Jun 29, 2023

Unblocks preview 6 by updating PGO data: #87807

@hoyosjs hoyosjs added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jun 29, 2023
@hoyosjs hoyosjs added this to the 8.0.0 milestone Jun 29, 2023
@hoyosjs hoyosjs self-assigned this Jun 29, 2023
@ghost
Copy link

ghost commented Jun 29, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Unblocks preview 6 by updating PGO data: #87807

Author: hoyosjs
Assignees: hoyosjs
Labels:

NO-MERGE, area-Infrastructure-libraries
Milestone: 8.0.0

jeffschwMSFT
jeffschwMSFT approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hoyosjs hoyosjs added the Servicing-approved Approved for servicing release label Jun 29, 2023
@lewing
Copy link
Member

lewing commented Jun 29, 2023

This can be merged without waiting for any of the mono lanes to complete

@carlossanlop
Copy link
Member

Is the CI failure related to this?

src\native\corehost\corehost.proj(152,5):
error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build)
The command ""D:\a\_work\1\s\src\native\corehost\build.cmd" Release x86 apphostver 8.0.0-ci hostver 8.0.0-ci fxrver 8.0.0-ci policyver 8.0.0-ci commit b0fb54aa12ac9624d3c8062462d76af80d2f467e outputrid win-x86 portable incremental-native-build rootdir D:\a\_work\1\s\ msbuild runtimeflavor CoreCLR runtimeconfiguration Release"
exited with code 1.

@jkotas
Copy link
Member

jkotas commented Jun 29, 2023

src\native\corehost\build.cmd" Release x86

This is #88172 (build break introduced by VS update on build machines)

@hoyosjs hoyosjs merged commit 5340be2 into dotnet:release/8.0-preview6 Jun 29, 2023
@hoyosjs hoyosjs deleted the juhoyosa/p6-update-pgo branch June 29, 2023 18:14
@hoyosjs
Copy link
Member Author

hoyosjs commented Jun 29, 2023

Confirmed the regression is fixed

@hoyosjs
Copy link
Member Author

hoyosjs commented Jun 29, 2023

Test failure was #84392. All other legs didn't exercise this path.

This was referenced Jun 29, 2023
Open
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffschwMSFT jeffschwMSFT jeffschwMSFT approved these changes

@jkotas jkotas jkotas approved these changes

Assignees

@hoyosjs hoyosjs

Labels
area-Infrastructure-libraries NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) Servicing-approved Approved for servicing release
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@hoyosjs @lewing @carlossanlop @jkotas @jeffschwMSFT