Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RISC-V] Disable Inline TLS field access on RISC-V #88584

Merged
merged 1 commit into from
Jul 10, 2023
Merged

[RISC-V] Disable Inline TLS field access on RISC-V #88584

merged 1 commit into from
Jul 10, 2023

Conversation

clamp03
Copy link
Member

@clamp03 clamp03 commented Jul 10, 2023

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 10, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 10, 2023
@ghost
Copy link

ghost commented Jul 10, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Part of #84834
cc @wscho77 @HJLeee @JongHeonChoi @t-mustafin @alpencolt @gbalykov

Author: clamp03
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@clamp03 clamp03 self-assigned this Jul 10, 2023
@clamp03 clamp03 added the arch-riscv Related to the RISC-V architecture label Jul 10, 2023
@clamp03
Copy link
Member Author

clamp03 commented Jul 10, 2023

Noti! @shushanhf I think LOONGARCH64 has the same issue.

@clamp03 clamp03 requested a review from jkotas July 10, 2023 02:18
@shushanhf
Copy link
Contributor

Noti! @shushanhf I think LOONGARCH64 has the same issue.

Yes, we had noted it and we are testing it locally by implementing it for LA.

jkotas
jkotas approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit caff01c into dotnet:main Jul 10, 2023
77 of 107 checks passed
@build-analysis build-analysis bot mentioned this pull request Jul 10, 2023
Closed
@clamp03 clamp03 deleted the disable_inlinetlsfieldaccess branch July 10, 2023 04:26
@runfoapp runfoapp bot mentioned this pull request Jul 10, 2023
Closed
@tomeksowi tomeksowi mentioned this pull request Jul 27, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@kunalspathak kunalspathak Awaiting requested review from kunalspathak

Assignees

@clamp03 clamp03

Labels
arch-riscv Related to the RISC-V architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clamp03 @shushanhf @jkotas