Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0-staging] Skip RC2 encrypted PKCS12 files on Android for iteration counting #88854

Conversation

vcsjones
Copy link
Member

Manual backport of #88787

This is a test-only change to address failures on Android.

@ghost
Copy link

ghost commented Jul 13, 2023

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Manual backport of #88787

This is a test-only change to address failures on Android.

Author: vcsjones
Assignees: vcsjones
Labels:

area-System.Security

Milestone: -

@vcsjones vcsjones added the test-bug Problem in test source code (most likely) label Jul 13, 2023
@vcsjones
Copy link
Member Author

/azp run runtime-android, runtime-androidemulator

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@vcsjones
Copy link
Member Author

Test failures look unrelated. Is there a way to get this to run through Android in release/7.0-staging?

@carlossanlop
Copy link
Member

/azp list

@azure-pipelines

This comment was marked as resolved.

@carlossanlop
Copy link
Member

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 88854 in repo dotnet/runtime

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Jul 13, 2023
@carlossanlop
Copy link
Member

Contacted Azure DevOps to ask for help with this error. Does not seem to be coming from our end.

@vcsjones
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 88854 in repo dotnet/runtime

@vcsjones
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vcsjones
Copy link
Member Author

Haha okay. Glad it worked. 🤷

@carlossanlop
Copy link
Member

Haha okay. Glad it worked. 🤷

I was just told that if you try multiple times, one of them ends up working.

@carlossanlop
Copy link
Member

@vcsjones let me know if you don't see anything concerning in the CI, and I can merge this for you.

@vcsjones
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 88854 in repo dotnet/runtime

@vcsjones
Copy link
Member Author

The tests timed out, so going to give it another shot on the weekend.

@vcsjones
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@akoeplinger
Copy link
Member

The Ubuntu.1804.Amd64.Android.29.Open servicing helix queue seems to be broken and doesn't provision VMs, I've pinged the infra folks.

@akoeplinger
Copy link
Member

The queue is back up, retried the builds.

@akoeplinger
Copy link
Member

Failures are unrelated, I checked the Android testResults.xml and the tests are correctly skipped there.

@akoeplinger akoeplinger merged commit 216f6ee into dotnet:release/7.0-staging Jul 17, 2023
@vcsjones vcsjones deleted the backport-dedaf46154a8938848fc9a7e0bd6e5ccebe7809c branch July 17, 2023 15:18
@vcsjones
Copy link
Member Author

vcsjones commented Jul 17, 2023

This should be back ported to release/6.0-staging since it will likely fail there as well. The odds of the diff applying cleanly are low, but I'll try backport bot, and if doesn't work, I'll open a manual port.

@vcsjones
Copy link
Member Author

/backport to release/6.0-staging

@github-actions
Copy link
Contributor

Started backporting to release/6.0-staging: https://github.com/dotnet/runtime/actions/runs/5577496919

@vcsjones
Copy link
Member Author

Wow. Backport command I will never doubt you again.

@radical radical mentioned this pull request Aug 3, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Security Servicing-approved Approved for servicing release test-bug Problem in test source code (most likely)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants