Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fedora docker image to Fedora 38 #90776

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

CarnaViire
Copy link
Member

@CarnaViire CarnaViire commented Aug 17, 2023

Prereq repo now only has Fedora 38 image. Which means, only it can be updated to the latest packages. And also, Fedora 36 is EOL.

System.Net.Quic had to update minimal required libmsquic package version to 2.2.2+ (#90228).
To be able to pull in the latest package, I've updated the image to Fedora 38. Without it, System.Net.Quic extra-platform tests are failing and outerloop is not running on Fedora at all (due to skipping if supported check fails).

@karelz If update goes smoothly, we might want to consider backporting this "test-infra-only" change to reduce noise in extra-platforms and bring back outerloop test coverage.

cc @ManickaP @wfurt

@ghost
Copy link

ghost commented Aug 17, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Prereq repo now only has Fedora 38 image. Which means, only it can be updated to the latest packages. And also, Fedora 36 is EOL.

System.Net.Quic had to update minimal required libmsquic package version to 2.2.2+ (#90228).
To be able to pull in the latest package, I've updated the image to Fedora 38. Without it, System.Net.Quic extra-platform tests are failing and outerloop is not running on Fedora at all (due to skipping if supported check fails).

@karelz If update goes smoothly, we might want to consider backporting this to reduce noise in extra-platforms and bring back outerloop test coverage.

cc @ManickaP @wfurt

Author: CarnaViire
Assignees: CarnaViire
Labels:

area-Infrastructure-libraries

Milestone: -

@CarnaViire
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CarnaViire
Copy link
Member Author

Fedora is used only if isExtraPlatforms=true or includeAllPlatforms=true 🤦‍♀️ pushed dummy commit to enable fedora temporarily, to run the tests

@CarnaViire
Copy link
Member Author

All tests on Fedora 38, including Quic tests, were executed successfully.

https://dev.azure.com/dnceng-public/public/_build/results?buildId=378445&view=logs&j=bc8f69e2-91b3-518c-84f8-466a04c1af40&t=0864dbdb-cb3f-5f82-b0b6-057b78db53e2&l=51

https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-90776-merge-94ac0ea7436e4b399d/System.Net.Quic.Functional.Tests/1/console.95d50a4b.log?helixlogtype=result

MsQuic supported and using 'libmsquic.so 2.2.2.377087 (b7b2d5e6df9c98ec8bad6d8dc8c6ef1a0e892abd)'.
  Discovered:  System.Net.Quic.Functional.Tests (found 124 of 134 test cases)
  Starting:    System.Net.Quic.Functional.Tests (parallel test collections = on, max threads = 2)
    System.Net.Quic.Tests.MsQuicPlatformDetectionTests.UnsupportedPlatforms_ThrowsPlatformNotSupportedException [SKIP]
      Condition(s) not met: "IsQuicUnsupported"
  Finished:    System.Net.Quic.Functional.Tests
=== TEST EXECUTION SUMMARY ===
   System.Net.Quic.Functional.Tests  Total: 358, Errors: 0, Failed: 0, Skipped: 1, Time: 114.231s

Reverting the dummy commit.

@CarnaViire
Copy link
Member Author

Test failures are unrelated

@CarnaViire
Copy link
Member Author

@ViktorHofer @carlossanlop PTAL

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@CarnaViire CarnaViire merged commit f8c110b into dotnet:main Aug 21, 2023
@CarnaViire
Copy link
Member Author

/backport to release/8.0

@github-actions
Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5941525683

@ghost ghost locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants