[release/8.0] Remove AD0001 NoWarn from Microsoft.Extensions.Logging.Abstractions project #91236
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-extensions-logging Issue DetailsBackport of #91222 to release/8.0 /cc @buyaa-n Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
|
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsBackport of #91222 to release/8.0 /cc @buyaa-n Customer ImpactEnabling AD0001 errors on this project would help finding analyzer bugs/issue as early as a servicing fix merged into this project. At the same time, the fix here is safe as we are not touching any product code. TestingNA RiskVery low, the fix is safe as we are not touching any product code. Though it could fail the build in case there is analyzer bug caused AD0001 with analyzers update or with a servicing fix merged into this project. Both case we would like to know the issue at build time IMPORTANT: If this backport is for a servicing release, please verify that:
|
There was a problem hiding this comment.
This is approved. Per comments in the main PR, porting this into the net8 branch ensures we have this analyzer enabled in the build there again, after we'd temporarily disabled it because of a bug in the analyzer.
@carlossanlop I think this is just a tell-mode type change since it's not affecting the product code, and therefore we don't need to ask Tactics. Do you agree?
|
Agreed. Tell mode. Will merge when CI is done and looks good. |
ghost
locked as resolved and limited conversation to collaborators
Backport of #91222 to release/8.0
/cc @buyaa-n
Customer Impact
Enabling AD0001 errors on this project would help finding analyzer bugs/issue as early as a servicing fix merged into this project. At the same time, the fix here is safe as we are not touching any product code.
Testing
NA
Risk
Very low, the fix is safe as we are not touching any product code. Though it could fail the build in case there is analyzer bug caused AD0001 with analyzers update or with a servicing fix merged into this project. Both case we would like to know the issue at build time
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.