Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm symbols 8 #92626

Closed
wants to merge 366 commits into from
Closed

wasm symbols 8 #92626

wants to merge 366 commits into from

Conversation

radical
Copy link
Member

@radical radical commented Sep 26, 2023

dotnet-bot and others added 30 commits August 25, 2023 19:40
… Build ID 2252827 (dotnet#91144)

* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2252827

* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2252827
…/8.0-rc1-to-release/8.0

[automated] Merge branch 'release/8.0-rc1' => 'release/8.0'
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
…1061)

Use underlying base type when deciding how to inline a
CreateInstance invocation in mini_emit_inst_for_method.

Fixes dotnet#90292
(Mono abort causing .NET 8 msbuild regression).

Co-authored-by: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
…tnet#91145)

* Fix diagnostic creation to ensure including the URI

* Fix the same issue with the Interop source gen

---------

Co-authored-by: Tarek Mahmoud Sayed <tarekms@microsoft.com>
* Update dependencies from https://github.com/dotnet/roslyn build 20230825.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23424.9 -> To Version 4.8.0-2.23425.1

* Update dependencies from https://github.com/dotnet/roslyn build 20230825.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23424.9 -> To Version 4.8.0-2.23425.2

* Update dependencies from https://github.com/dotnet/roslyn build 20230825.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23424.9 -> To Version 4.8.0-2.23425.3

* Update dependencies from https://github.com/dotnet/roslyn build 20230826.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23424.9 -> To Version 4.8.0-2.23426.1

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…ation (dotnet#91172)

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230826.6

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23362.5 -> To Version 1.0.0-prerelease.23426.6

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230827.2

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23362.5 -> To Version 1.0.0-prerelease.23427.2

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Ivan Povazan <ivan.povazan@gmail.com>
…/arcade (dotnet#91154)

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20230825.3

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23424.2 -> To Version 3.11.0-beta1.23425.3

* Update dependencies from https://github.com/dotnet/arcade build 20230825.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23422.1 -> To Version 8.0.0-beta.23425.2

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23418.1 -> To Version 1.0.0-beta.23423.1 (parent: Microsoft.DotNet.Arcade.Sdk

* Update testPackages.proj

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
…parameters (dotnet#91094) (dotnet#91231)

Recommend that methods with array parameters use [In] or [Out] attributes if there are none already, and the parameter is not in, ref, or out.
…roject (dotnet#91236)

Co-authored-by: Buyaa Namnan <bunamnan@microsoft.com>
…ponseServerError_ClientWrite test (dotnet#91271)

* Add Task.Delay to give more time for reset frame

* Apply James' solution

---------

Co-authored-by: Ahmet Ibrahim Aksoy (from Dev Box) <aaksoy@microsoft.com>
…es (dotnet#91266)

* JIT: Fix LowerHWIntrinsicToScalar with unused values

Fix dotnet#91173

* Fix more cases

---------

Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com>
… to handle static virtual methods (dotnet#91059)

* Extend mono_gsharedvt_constrained_call JIT icall to handle static virtual methods

* Handle static virtual calls in constrained_gsharedvt_call_setup

* Fix lint

* Add runtime test

* Remove runtime test

---------

Co-authored-by: Milos Kotlar <kotlarmilos@gmail.com>
…otnet#91270)

* Fix unsafe accessor related issue for full aot

* Only skip for WRAPPER_SUBTYPE_UNSAFE_ACCESSOR

---------

Co-authored-by: Fan Yang <yangfan@microsoft.com>
Co-authored-by: Fan Yang <yangfan@microsoft.com>
…s thread pool is being used (dotnet#91246)

* Add boolean field to indicate whether or not the Windows thread pool is being used

* Update src/libraries/System.Private.CoreLib/src/System/Threading/ThreadPool.Windows.cs

Co-authored-by: Stephen Toub <stoub@microsoft.com>

* Remove trailing spaces

* Move comment

* Update fields and comments

* Disable CA1823 - unused field

---------

Co-authored-by: unknown <eduardo.velarde@pucp.pe>
Co-authored-by: Eduardo Velarde <32459232+eduardo-vp@users.noreply.github.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
…net/hotreload-utils dotnet/source-build-reference-packages (dotnet#91264)

* Update dependencies from https://github.com/dotnet/cecil build 20230828.2

Microsoft.DotNet.Cecil
 From Version 0.11.4-alpha.23421.1 -> To Version 0.11.4-alpha.23428.2

* Update dependencies from https://github.com/dotnet/arcade build 20230828.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23425.2 -> To Version 8.0.0-beta.23428.2

* Update dependencies from https://github.com/dotnet/hotreload-utils build 20230828.3

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 8.0.0-alpha.0.23421.1 -> To Version 8.0.0-alpha.0.23428.3

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230828.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.23424.1 -> To Version 8.0.0-alpha.1.23428.2

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
…emory (dotnet#91277)

* EmccMaximumHeapSize to define maximum memory

* Fix typo in comment

* Space in param use

---------

Co-authored-by: Marek Fišera <mara@neptuo.com>
…oader lock (dotnet#91327)

* [mono][metadata] Replace use of mem manager lock with loader lock

Hash table operations under the mem manager lock could end up taking the loader lock when performing type comparison, in the case where custom modifiers needed to be loaded. Use the loader lock instead to prevent deadlocks.

* [mono][metadata] Use loader lock during generic class hash table lookup

---------

Co-authored-by: Vlad Brezae <brezaevlad@gmail.com>
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
…et#91046)

* Use WasmSdk in browser template

* Remove default html-path

* Use wwwroot when looking for main.js in template for replacement

* Temporarily remove WasmRuntimeAssetsLocation from WBT because WasmSDK doesn't support it yet

* Integrate console log forward into DevServer

* Replace UseRouter

* Use next middleware only if it's not console

* CancellationTokenSource on CancelKeyPress

* Address feedback from initial DevServer integration

* Update src/mono/wasm/host/BrowserHost.cs

Co-authored-by: Ankit Jain <radical@gmail.com>

* Remove debugging code

* Fix WBT

* Fix starting outside of project directory

* Support WasmRuntimeAssetsLocation in Wasm SDK

* Revert "Support WasmRuntimeAssetsLocation in Wasm SDK"

* Active issue for WasmRuntimeAssetsLocation

* Feedback

---------

Co-authored-by: Marek Fišera <mara@neptuo.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
…829.1 (dotnet#91329)

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23428.2 -> To Version 8.0.0-beta.23429.1

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23423.1 -> To Version 1.0.0-beta.23426.1 (parent: Microsoft.DotNet.Arcade.Sdk

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…otnet-optimization build 20230829.4 (dotnet#91330)

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23427.2 -> To Version 1.0.0-prerelease.23429.4

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Tanner Gooding <tagoo@outlook.com>
… on separate line (dotnet#91218)

* Emit interceptor info correctly when invocation expr is on separate line

* Add more tests and add helper to udpate baselines

* Add comments to binding gen tests for invocations on new lines (dotnet#91237)

* Add comments to binding gen tests for invocations on new lines

* Address feedback & test static method call syntax

* Reorganize and comment the newline/whitespace scenarios

* Reorganize and comment the newline/whitespace scenarios for ConfigurationExtensions

---------

Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>

* Update baselines

---------

Co-authored-by: Layomi Akinrinade <laakinri@microsoft.com>
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
…dotnet#91346)

* Fix crash when calling AssemblyLoadContext.Unload twice

The AssemblyLoadContext.InitiateUnload method was not handling multiple
calls correctly. Instead of making the extra calls dummy, it was
calling the native runtime helper again.

This change fixes it by simply ensuring that the runtime helper is
called just once.

* Add regression test

---------

Co-authored-by: Jan Vorlicek <janvorli@microsoft.com>
carlossanlop and others added 5 commits September 25, 2023 13:28
…/8.0-rc2-to-release/8.0

[automated] Merge branch 'release/8.0-rc2' => 'release/8.0'
.. so that can work even if they get renamed during minimization.
The earlier change was done in 678fd6a,
which changed to pass `-g` to the link step also. But that resulted in
increased native file sizes.

Changed sizes for the `minimum blazor template - publish` scenario:

```
                                                          | Last rc1 run     | With the change
----------------------------------------------------------|----------------- |------------------
SOD - Minimum Blazor Template - Publish                   |8590723.000 bytes |7889806.000 bytes
Total Uncompressed _framework                             |4304274.000 bytes |4202273.000 bytes
pub/wwwroot/_framework/dotnet.js                          |35722.000 bytes   |35838.000 bytes
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js     |239307.000 bytes  |134566.000 bytes
pub/wwwroot/_framework/dotnet.native.wasm                 |1174394.000 bytes |1148841.000 bytes
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js    |221356.000 bytes  |221712.000 bytes
```
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@radical radical closed this Sep 26, 2023
@radical radical deleted the wasm-symbols-8 branch September 26, 2023 07:30
@radical radical restored the wasm-symbols-8 branch September 26, 2023 07:30
@ghost
Copy link

ghost commented Sep 26, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: radical
Assignees: -
Labels:

arch-wasm

Milestone: -

@ghost
Copy link

ghost commented Sep 26, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: radical
Assignees: radical
Labels:

arch-wasm, area-System.Reflection.Metadata, new-api-needs-documentation

Milestone: -

@radical radical deleted the wasm-symbols-8 branch September 27, 2023 03:37
@ghost ghost locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.