[release/8.0] [mono][aot] Avoid compiling the same method multiple times during dedup. #92178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
vargaz,
lambdageek and
SamMonoRT
as code owners
|
/azp run runtime-wasm |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsBackport of #91802 to release/8.0 /cc @vargaz Customer ImpactFixes build time problems in large WASM projects which use AOT. TestingOn CI. RiskLow, only affects wasm AOT/ios. IMPORTANT: If this backport is for a servicing release, please verify that:
|
SamMonoRT
approved these changes
Sep 16, 2023
|
@marek-safar - need your approval to merge before RC2 cutoff on Monday. |
marek-safar
approved these changes
Sep 17, 2023
vargaz
added
Servicing-approved
|
@carlossanlop - this is ready to be merged |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #91802 to release/8.0
/cc @vargaz
Customer Impact
Fixes build time problems in large WASM projects which use AOT.
Testing
On CI.
Risk
Low, only affects wasm AOT/ios.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.