-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] Replace http.error.reason with OTel standard error.type #91996
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #91910 to release/8.0 /cc @antonfirsov Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
The massive failures in |
/azp run runtime |
Azure Pipelines successfully started running 1 pipeline(s). |
I approve - it is a new 8.0 feature and we are aligning with latest OpenTelemetry spec update, preventing breaking change in 9.0. @artl93 it is ready for your approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
M2 Approved.
Backport of #91910 to release/8.0
/cc @antonfirsov
Fixes #91909
Customer Impact
Align attribute name and semantics with the OpenTelemetry spec (which was finalized 2023/9/11 - see open-telemetry/semantic-conventions#205) --
http.error.reason
attribute has been standardized under nameerror.type
. We need to:http.error.reason
toerror.type
.error.type
also for valid responses where the HTTP status code indicates an error (4xx or 5xx) -- in such case, the value should be the string representation of the HTTP status code.http.error.reason
only when the underlying handler fails to fetch a response.See
error.type
in the spec for more details.For context: We introduced the attribute
http.error.reason
in PR #89809 (on 2023/8/3) based on the in-progress draft of the OTel spec (open-telemetry/semantic-conventions#205).Given that this is new 8.0 feature, we should adapt to the spec in 8.0 to avoid breaking changes with 9.0.
Testing
A test has been added for the new
error.type
behavior.Risk
Low. RC1 users experimenting with HttpClient Metrics may experience an inconvenience with the rename. (It's unlikely there are many at this point.)