[release/8.0] Numerics and Tensors backport #92245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otnet#91228) * Adding a naive implementation of various primitive tensor operations * Adding tests covering the new tensor primitives APIs * Adding tensor primitives APIs to the ref assembly * Allow .NET Framework to build/run * Sync TFMs between ref and src, csproj simplication and clean-up * Apply suggestions from code review Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> * Don't use var * Fix the S.N.Tensors readme and remove the file marking it as non-shipping --------- Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> Co-authored-by: Michael Sharp <51342856+michaelgsharp@users.noreply.github.com>
* Start vectorizing TensorPrimitives Just does two functions to establish the files into which the rest of the implementations can be moved.
* 6 more naive methods * updates from pr comments
* Add remaining set of TensorPrimitives APIs for .NET 8 Adds non-vectorized implementations of: - Max - Min - MaxMagnitude - MinMagnitude - IndexOfMax - IndexOfMin - IndexOfMaxMagnitude - ConvertToHalf (only on .NET Core) - ConvertToSingle (only on .NET Core) - IndexOfMinMagnitude Adds vectorized implementations of: - Sum - SumOfSquares - SumOfMagnitudes - Product - ProductOfSums - ProductOfDifferences Also includes the helpers that'll make it trivial to vectorize Dot. Beyond vectorizing the non-vectorized ones, the vectorized implementations should be improved further, including: - Handling alignment better - Vectorizing the remainder that doesn't fit in a vector rather than falling back to scalar * Cleanup after previous PR, vectorize CosineSimilarity/Dot/L2Normalize/Distance, add tests * Address PR feedback, and fix a few other issues
ghost
assigned 
dotnet-issue-labeler
bot
added
needs-area-label
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
ericstj
reviewed
Sep 18, 2023
ericstj
changed the title
* bcl numberics library added * bcl done * added explicit 2.1 target * Minor doc updates * Apply suggestions from code review Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> * fixes from PR comments * minor csproj fixes * fixed ref target frameworks * minor ref csproj updates * minor csproj updates --------- Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
…mSource. (dotnet#91402) * Microsoft.Bcl.Numerics.Tests: fix restore failure when DotNetBuildFromSource. * Use NetCoreAppCurrent. * Try fix CI test failures.
|
Those commits have been added. |
ericstj
added
area-System.Numerics.Tensors
Servicing-consider
|
Tagging subscribers to this area: @dotnet/area-system-numerics-tensors Issue DetailsBackporting the new BCL.Numerics and Tensors packages. Customer ImpactTestingRisk
|
jeffhandley
approved these changes
Sep 18, 2023
artl93
added
Servicing-approved
artl93
approved these changes
Sep 19, 2023
|
@michaelgsharp the CI failed in this PR: some Tensors types are not found. Can you please take a look tomorrow, since it's affecting the release/8.0 branch? |
This was referenced Sep 19, 2023
|
|
I'll get this fixed ASAP. Looks like a couple ifdefs are missing. Must not be hit in |
I already put up the prs for it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting the new BCL.Numerics and Tensors packages.
Customer Impact
Adds in MathF support for older frameworks so people don't have to roll their own. This allows for us and for 3rd parties to remove duplicated code in places where we are doing this ourselves.
The Tensors code adds in some missing math features that will be able to be hardware accelerated increasing the performance.
Testing
All new API's have automated testing.
Risk
Risk should be minimal to none. the BCL package is a new package adding in MathF support to older frameworks. The Tensors package hasn't been shipped for many releases, so these changes shouldn't affect anyone. And since we aren't changing existing API's, new automated testing should be enough to mitigated any risks.