Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-rc2] Address feedback and fix some TensorPrimitives issues #92437

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 21, 2023

Backport of #92395 to release/8.0-rc2

/cc @michaelgsharp @stephentoub

Customer Impact

Final changes needed to get the package ready for preview by Semantic Kernel and ML.NET.

Testing

Automated testing in place.

Risk

Very low. These are changes to a new API in a new library we haven't shipped before. No one has any dependencies on them yet.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

- Added a few APIs based on initial feedback: Abs (vectorized), Log2, and element-wise Max/Min{Magnitude}
- Renamed L2Normalize to Norm
- Fixed semantics of Min/MaxMagnitude to return original value rather than the absolute value
- Renamed a few helper types for consistency
- Added tests
@dotnet-issue-labeler dotnet-issue-labeler bot added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Sep 21, 2023
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ericstj ericstj added Servicing-consider Issue for next servicing release review area-System.Numerics.Tensors and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 21, 2023
@ghost
Copy link

ghost commented Sep 21, 2023

Tagging subscribers to this area: @dotnet/area-system-numerics-tensors
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #92395 to release/8.0-rc2

/cc @michaelgsharp @stephentoub

Customer Impact

Final changes needed to get the package ready for preview by Semantic Kernel and ML.NET.

Testing

Automated testing in place.

Risk

Very low. These are changes to a new API in a new library we haven't shipped before. No one has any dependencies on them yet.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

Servicing-consider, area-System.Numerics.Tensors, new-api-needs-documentation

Milestone: -

@carlossanlop
Copy link
Member

Approved by Tactics via email.

@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 22, 2023
@carlossanlop carlossanlop added this to the 8.0.0 milestone Sep 22, 2023
@carlossanlop carlossanlop merged commit 63d0c64 into release/8.0-rc2 Sep 22, 2023
107 of 115 checks passed
@carlossanlop carlossanlop deleted the backport/pr-92395-to-release/8.0-rc2 branch September 22, 2023 01:58
@radical radical mentioned this pull request Sep 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants