[release/8.0] Remove public provider from rundown session #92048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
|
@davmason please fill out the template, get a code owner sign-off, and add the |
carlossanlop
added
the
Servicing-consider
|
@jeffschwMSFT can we get your autograph? |
jeffschwMSFT
approved these changes
Sep 15, 2023
jeffschwMSFT
added
Servicing-approved
|
@lateralusX can you please sign-off the backport too? Or alternatively @lambdageek @noahfalk @brianrob @MichalStrehovsky who were added as reviewers in the main PR. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #91383 to release/8.0
/cc @davmason
Customer Impact
When we created EventPipe we mimicked the rundown logic from Perfview, which enabled the public Microsoft-Windows-DOTNETRuntime provider during rundown to support pre v4 runtimes. This has the unintended side effect of introducing unwanted events in to traces - e.g. if a user configured a trace without GC events we would have GC events emitted during rundown. This has the potential to confuse some analysis tools.
Testing
A CI run with a change that would failfast if we saw a non-rundown provider being fired on a rundown thread, plus manual verification with the dotnet-* tools.
Risk
Low - we could not identify any non rundown events that are emitted or any tools that expect those events to be emitted during rundown.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.