Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0] Fix wasi build. #92232

Merged
merged 3 commits into from
Sep 18, 2023
Merged

[release/8.0] Fix wasi build. #92232

merged 3 commits into from
Sep 18, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 18, 2023 •
edited by vargaz
Loading

Backport of #92216 to release/8.0

/cc @vargaz

Customer Impact

Some docker containers in eng/pipelines/common/templates/pipeline-with-resources.yml used floating versions so
updating the container could break CI builds on both master and 8.0.

Testing

CI

Risk

Only affects wasi lanes which are currently broken.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Sep 18, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #92216 to release/8.0

/cc @vargaz

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-libraries
Milestone: -

@vargaz vargaz requested a review from marek-safar September 18, 2023 17:06
@vargaz vargaz added this to the 8.0.0 milestone Sep 18, 2023
@vargaz vargaz added the Servicing-consider Issue for next servicing release review label Sep 18, 2023
@steveisok steveisok mentioned this pull request Sep 18, 2023
Merged
carlossanlop
carlossanlop approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is tell-mode. Approving to unblock the CI.

@carlossanlop carlossanlop added Servicing-approved Approved for servicing release area-Infrastructure-libraries and removed Servicing-consider Issue for next servicing release review labels Sep 18, 2023
@ghost
Copy link

ghost commented Sep 18, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #92216 to release/8.0

/cc @vargaz

Customer Impact

Some docker containers in eng/pipelines/common/templates/pipeline-with-resources.yml used floating versions so
updating the container could break CI builds on both master and 8.0.

Testing

CI

Risk

Only affects wasi lanes which are currently broken.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

Servicing-approved, area-Infrastructure-libraries, area-Build-mono
Milestone: 8.0.0

@lewing
Copy link
Member

lewing commented Sep 18, 2023

This is infrastructure only

@carlossanlop
Copy link
Member

carlossanlop commented Sep 18, 2023 •
edited
Loading

Once the wasi-wasm linux legs pass, we can merge this and the deps flow PR #92143 can get the branch updated.

  • Build wasi-wasm linux Release LibraryTests_Smoke
  • Build wasi-wasm linux Release WasmBuildTests

@carlossanlop
Copy link
Member

@lewing does Build wasi-wasm linux Release WasmBuildTests need to be queued manually with an /azp command? I don't see it showing up among the running CI legs. I only see Build wasi-wasm linux Release LibraryTests_Smoke.

@SamMonoRT
Copy link
Member

@lewing does Build wasi-wasm linux Release WasmBuildTests need to be queued manually with an /azp command? I don't see it showing up among the running CI legs. I only see Build wasi-wasm linux Release LibraryTests_Smoke.

"/azp run runtime-wasm" triggers additional wasm lanes.

@lewing
Copy link
Member

lewing commented Sep 18, 2023

@radical would know the details

@radical
Copy link
Member

radical commented Sep 18, 2023

/azp run runtime-wasm-non-libtests

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@radical
Copy link
Member

radical commented Sep 18, 2023

@lewing does Build wasi-wasm linux Release WasmBuildTests need to be queued manually with an /azp command? I don't see it showing up among the running CI legs. I only see Build wasi-wasm linux Release LibraryTests_Smoke.

The WBT jobs are triggered when we have changes specific to wasi, but it trigger for changes in eng/pipelines/common/templates/pipeline-with-resources.yml.

@radical
Copy link
Member

radical commented Sep 18, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@carlossanlop
Copy link
Member

carlossanlop commented Sep 18, 2023 •
edited
Loading

Build wasi-wasm linux Release LibraryTests_Smoke already finished. I still don't see Build wasi-wasm linux Release WasmBuildTests after the /azp run, but given that the failure was showing up exactly the same way on both CI legs, I will assume the failure is fixed on both. Let me know if you disagree. Otherwise, I'll merge this in a few minutes.

Edit: I see your dummy change, @radical 😄

@carlossanlop
Copy link
Member

Merging now given that one of the two legs passed. If I see anything else that is wrong in the rolling builds or other PRs, I'll let you know.

@carlossanlop carlossanlop merged commit 644856c into release/8.0 Sep 18, 2023
@carlossanlop carlossanlop deleted the backport/pr-92216-to-release/8.0 branch September 18, 2023 18:43
This was referenced Sep 18, 2023
Open
Closed
Closed
radical pushed a commit to radical/runtime that referenced this pull request Sep 20, 2023
@github-actions @radical
[release/8.0] Fix wasi build. (dotnet#92232)
380c3db 
* Fix wasi build.

* dummy change in wasi README to trigger a build

* dummy change in wasi to trigger a build

---------

Co-authored-by: Zoltan Varga <vargaz@gmail.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
(cherry picked from commit 644856c)
@radical
Copy link
Member

radical commented Sep 20, 2023

/backport to release/8.0-rc1

@github-actions
Copy link
Contributor Author

Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/6253330728

@github-actions github-actions bot mentioned this pull request Sep 20, 2023
Merged
@radical radical mentioned this pull request Sep 26, 2023
Closed
@radical radical mentioned this pull request Oct 3, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

@lewing lewing lewing approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

Assignees
No one assigned
Labels
area-Build-mono area-Infrastructure-libraries Servicing-approved Approved for servicing release
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lewing @carlossanlop @SamMonoRT @radical @vargaz