[release/8.0-rc2] [Mono]: Add missing case for constrained gsharedvt call. #92347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
1b788f4 added a new value to our MonoRgctxInfoType enum type, but appears that all cases where not full adjusted. Running System.Buffers tests in full AOT hits the assert in info_equal about missing case, https://github.com/dotnet/runtime/blob/0dc5903679606b072adac70a268cdb77d1147b3e/src/mono/mono/mini/mini-generic-sharing.c#L2908. This commit adds the new enum value and align handling similar to other cases added by that commit.
github-actions
bot
requested review from
vargaz,
lambdageek and
SamMonoRT
as code owners
vargaz
approved these changes
Sep 20, 2023
|
This is targeting release/8.0, which represents RTM now. If you want this change to go into RC2, there is still time, so please retarget the PR to release/8.0-rc2. If you don't know, you can edit the PR title and change the desired target branch there. For either case, please fill out the template, request Tactics approval, get a code review sign off, and confirm the CI looks good. |
steveisok
added
Servicing-consider
|
Approved over email by tactics |
lateralusX
changed the title
Closed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #92338 to release/8.0-rc2
/cc @lateralusX
Customer Impact
In running full aot tests on Windows, we noticed a missing case when handling constrained gsharedvt calls. This would result in asserts in a lot of library tests. The fix was to add a new value to the MonoRgctxInfoType enum and handle the case where it's hit.
Testing
Ran full aot automated tests and they now pass.
Risk
Low, adds a switch case which would assert otherwise.