Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-rc2] [browser] Fix SIMD+EH check #92439

Merged
merged 5 commits into from
Sep 22, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 21, 2023

Backport of #92348 to release/8.0

/cc @lewing @maraf

Customer Impact

Fix support for running WASM application on older browsers without SIMD or EH.
The app itself is build correctly, but additional check on runtime was incorrect.

Testing

Manual. Automated test TBD

Risk

Low

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@lewing lewing added Servicing-consider Issue for next servicing release review arch-wasm WebAssembly architecture labels Sep 21, 2023
@ghost
Copy link

ghost commented Sep 21, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #92348 to release/8.0

/cc @lewing @maraf

Customer Impact

Fix support for running WASM application on older browsers without SIMD or EH.
The app itself is build correctly, but additional check on runtime was incorrect.

Testing

Manual. Automated test TBD

Risk

Low

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

Servicing-consider, arch-wasm, area-System.Runtime.InteropServices.JavaScript

Milestone: -

@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 21, 2023
@carlossanlop
Copy link
Member

Approved by Tactics via email. This one has no suspicious commits @radical 😄.

@carlossanlop carlossanlop added this to the 8.0.0 milestone Sep 21, 2023
@carlossanlop carlossanlop merged commit b1dbbb9 into release/8.0-rc2 Sep 22, 2023
34 of 38 checks passed
@carlossanlop carlossanlop deleted the backport/pr-92348-to-release/8.0-rc2 branch September 22, 2023 01:54
@radical radical mentioned this pull request Sep 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants