[release/8.0] JIT: DNER multiregs with SIMD12 #91878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Locals with SIMD12 fields will never match the ABI when they end up as multireg returns, so these should always be DNER'd. Fix dotnet#91214
ghost
assigned 
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBackport of #91674 to release/8.0 Customer ImpactThe JIT will incorrectly handle structs of size 16 that contain TestingRegression test included. RiskLow. Fall back to more conservative treatment in the affected cases.
|
jeffschwMSFT
approved these changes
Sep 11, 2023
EgorBo
approved these changes
Sep 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #91674 to release/8.0
Customer Impact
The JIT will incorrectly handle structs of size 16 that contain
Vector3on Unix x64 ABIs and on ARM64. Bad codegen or JIT crashes can happen when these structs are returned from functions or are passed to them.Testing
Regression test included.
Risk
Low. Fall back to more conservative treatment in the affected cases.