[release/8.0] Implement support for InlineArray in the trimmer
#92107
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Types annotated with `InlineArray` need to preserve all of their fields, even if otherwise this would not be the case. It's possible to have a struct with `LayoutKind.Auto` and with `InlineArray` - trimmer would normally trim fields on such struct. This leads to corruption since the field is never accessed directly. This changes the marking to preserve all fields on a type with `InlineArray` attribute just like we would for explicit layout struct and similar other types. Adds tests to cover both the explicit usage of `InlineArray` attribute as well as the compiler generate usage via collection literals.
…rrayDataflow.cs Co-authored-by: Sven Boemer <sbomer@gmail.com>
dotnet-issue-labeler
bot
added
the
needs-area-label
carlossanlop
added
area-Tools-ILLink
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas Issue DetailsBackport of #92060 to release/8.0 /cc @vitek-karas Customer ImpactWithout this fix applications using some C# 12 Collection Literals or directly using TestingAdded tests for several different cases, both via collection literals as well as direct attribute usage. Verified that a repro app from a user works. RiskLow - the change modifies the trimmer to include fields on more types than before. It doesn't remove anything which was not removed before. IMPORTANT: If this backport is for a servicing release, please verify that:
|
|
@agocke @sbomer can we get your code review sign-off in the backport too? @vitek-karas are the failures related? @jeffschwMSFT do we have your approval for this? |
ghost
locked as resolved and limited conversation to collaborators
Backport of #92060 to release/8.0
/cc @vitek-karas
Customer Impact
Without this fix applications using some C# 12 Collection Literals or directly using
InlineArrayAttributemay not work when trimmed.Testing
Added tests for several different cases, both via collection literals as well as direct attribute usage. Verified that a repro app from a user works.
Risk
Low - the change modifies the trimmer to include fields on more types than before. It doesn't remove anything which was not removed before.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.