[iOS][non-icu] HybridGlobalization implement japanese calendar data #92471

mkhamoyan · 2023-09-22T11:43:30Z

Implement japanese calendar methods for hybrid mode on Apple platforms.

GetCalendars
GetLatestJapaneseEra
GetJapaneseEraStartDate

Contributes to #80689

ghost · 2023-09-22T11:43:42Z

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Implement below methods for hybrid mode on Apple platforms.

GetCalendars
GetLatestJapaneseEra
GetJapaneseEraStartDate

Contributes to #80689

cc @SamMonoRT

Author:	mkhamoyan
Assignees:	mkhamoyan
Labels:	`area-System.Globalization`
Milestone:	-

mkhamoyan · 2023-09-22T15:55:35Z

/azp run runtime-ioslike

azure-pipelines · 2023-09-22T15:55:43Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost · 2023-09-22T16:11:45Z

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

Implement japanese calendar methods for hybrid mode on Apple platforms.

GetCalendars
GetLatestJapaneseEra
GetJapaneseEraStartDate

Contributes to #80689

cc @SamMonoRT

Author:	mkhamoyan
Assignees:	mkhamoyan
Labels:	`area-System.Globalization`, `os-ios`
Milestone:	-

src/native/libs/System.Globalization.Native/pal_calendarData.h

src/native/libs/System.Globalization.Native/pal_calendarData.m

src/libraries/System.Private.CoreLib/src/System/Globalization/JapaneseCalendar.cs

src/libraries/System.Private.CoreLib/src/System/Globalization/JapaneseCalendar.iOS.cs

src/native/libs/System.Globalization.Native/pal_calendarData.m

mkhamoyan · 2023-09-25T15:14:56Z

/azp run runtime-ioslike

azure-pipelines · 2023-09-25T15:15:12Z

Azure Pipelines successfully started running 1 pipeline(s).

src/native/libs/System.Globalization.Native/pal_calendarData.m

mdh1418 · 2023-10-05T14:35:05Z

src/native/libs/System.Globalization.Native/pal_calendarData.m

+        NSString *defaultCalendarIdentifier = [currentLocale calendarIdentifier];
+        int32_t calendarCount = MIN(calendarIdentifiers.count, calendarsCapacity);
+        int32_t calendarIndex = 0;
+        calendars[calendarIndex++] = GetCalendarId([defaultCalendarIdentifier UTF8String]);


Theres a possibility of this being UNINITIALIZED_VALUE right? It doesn't seem like we should be setting this if its not a known calendar Id. Which highlights that there are more calendars in the calendarIdentifiers list than in the known calendarIds in GetCalendarId. Should we expand the coverage of GetCalendarId and GetCalendarIdentifier?

Nice catch, I will update it.

Updated the part related to UNINITIALIZED_VALUE , but for expanding coverage in GetCalendarId and GetCalendarIdentifier, looks like it is not smth that we support in C# side with current implementation. Supported calendars are implemented in C# like for example https://github.com/mkhamoyan/runtime/blob/main/src/libraries/System.Private.CoreLib/src/System/Globalization/JapaneseCalendar.cs . I guess I can open a ticket to see if we can implement more calendars that are supported by NSCalendarIdentifier. What do you think?

mdh1418 · 2023-10-05T15:21:58Z

src/libraries/System.Private.CoreLib/src/System/Globalization/JapaneseCalendar.Icu.cs

+            else
+            {
+                string[]? abbrevEraNames;
+                if (!CalendarData.EnumCalendarInfo("ja", CalendarId.JAPAN, CalendarDataType.AbbrevEraNames, out abbrevEraNames))


Could we still use out abbrevEnglishEraNames! directly instead like in the non-apple block? So making this else block the same as the non-apple block

Updated it.

mkhamoyan · 2023-10-06T08:53:08Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-10-06T08:53:22Z

Azure Pipelines successfully started running 1 pipeline(s).

src/native/libs/System.Globalization.Native/pal_calendarData.m

mkhamoyan · 2023-10-09T08:07:03Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-10-09T08:07:17Z

Azure Pipelines successfully started running 1 pipeline(s).

mdh1418

Looks good to me! Thanks!

mkhamoyan · 2023-10-09T13:41:21Z

Failures are not related.

Add japanese calendar function for hybrid mode

19dc7e8

dotnet-issue-labeler bot added the area-System.Globalization label Sep 22, 2023

ghost assigned mkhamoyan Sep 22, 2023

Merge branch 'main' into hybrid_japanese_calendar

2c4e707

mkhamoyan requested review from steveisok, akoeplinger and mdh1418 September 22, 2023 12:58

mkhamoyan mentioned this pull request Sep 22, 2023

[iOS][HybridGlobalization] Exclude not used resources from icu file dotnet/icu#384

Merged

mkhamoyan added 2 commits September 22, 2023 15:19

Minor refactoring

f932247

Refactor GetJapaneseEraStartDateNative

7011aa9

mkhamoyan marked this pull request as ready for review September 22, 2023 15:54

mkhamoyan requested a review from ilonatommy September 22, 2023 15:56

tarekgh added the os-ios Apple iOS label Sep 22, 2023

mdh1418 reviewed Sep 22, 2023

View reviewed changes

ilonatommy reviewed Sep 25, 2023

View reviewed changes

Refactored as requested by review

4e3a1d9

mkhamoyan requested a review from mdh1418 September 25, 2023 15:05

mdh1418 reviewed Sep 25, 2023

View reviewed changes

src/native/libs/System.Globalization.Native/pal_calendarData.m Outdated Show resolved Hide resolved

mdh1418 reviewed Sep 25, 2023

View reviewed changes

src/native/libs/System.Globalization.Native/pal_calendarData.m Outdated Show resolved Hide resolved

build-analysis bot mentioned this pull request Oct 4, 2023

System.Data.OleDb.Tests timeout in net48 x86 Release leg #87783

Open

mkhamoyan requested a review from mdh1418 October 5, 2023 08:20

mdh1418 reviewed Oct 5, 2023

View reviewed changes

refactor as requested by review

b04b27e

This was referenced Oct 5, 2023

Test_EventSource_EtwManifestGeneration* tests failing in CI #48798

Closed

Test infra failure on iOS.Device.Aot.Test.WorkItemExecution CI leg #92792

Closed

JIT/SIMD/CircleInConvex_[r]/[ro] are failing on arm64 Mono interpreter #92925

Closed

mkhamoyan added 2 commits October 6, 2023 10:49

Refactor GlobalizationNative_GetCalendarsNative

33f6a7e

Merge branch 'main' into hybrid_japanese_calendar

7fa2128

mkhamoyan requested a review from mdh1418 October 6, 2023 08:53

This was referenced Oct 6, 2023

NuGet failing with Response status code does not indicate success: 503 (Service Unavailable) dotnet/arcade#11723

Open

MSBuild crashing in the build #92290

Open

[mono][tests] The type initializer for 'NetSecurityNative' threw an exception #93104

Closed

mdh1418 reviewed Oct 6, 2023

View reviewed changes

src/native/libs/System.Globalization.Native/pal_calendarData.m Outdated Show resolved Hide resolved

mdh1418 reviewed Oct 6, 2023

View reviewed changes

src/native/libs/System.Globalization.Native/pal_calendarData.m Outdated Show resolved Hide resolved

mkhamoyan mentioned this pull request Oct 9, 2023

[iOS][non-icu] HybridGlobalization investigate/implement NSCalendarIdentifier not implemented calendars #93199

Closed

Remove not used calendar types

b17c33a

mkhamoyan requested a review from mdh1418 October 9, 2023 08:07

mdh1418 approved these changes Oct 9, 2023

View reviewed changes

mkhamoyan merged commit a5461cb into dotnet:main Oct 9, 2023
228 of 248 checks passed

mkhamoyan deleted the hybrid_japanese_calendar branch October 9, 2023 13:42

This was referenced Oct 9, 2023

Tracking issue for CI build timeouts #76454

Closed

[mono][aot] Precompiling failed for System.Private.CoreLib.dll with exit code 134 #93188

Closed

ghost locked as resolved and limited conversation to collaborators Nov 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[iOS][non-icu] HybridGlobalization implement japanese calendar data #92471

[iOS][non-icu] HybridGlobalization implement japanese calendar data #92471

mkhamoyan commented Sep 22, 2023 •

edited

Loading

ghost commented Sep 22, 2023

mkhamoyan commented Sep 22, 2023

azure-pipelines bot commented Sep 22, 2023

ghost commented Sep 22, 2023

mkhamoyan commented Sep 25, 2023

azure-pipelines bot commented Sep 25, 2023

mdh1418 Oct 5, 2023

mkhamoyan Oct 5, 2023

mkhamoyan Oct 6, 2023

mdh1418 Oct 5, 2023 •

edited

Loading

mkhamoyan Oct 5, 2023

mkhamoyan commented Oct 6, 2023

azure-pipelines bot commented Oct 6, 2023

mkhamoyan commented Oct 9, 2023

azure-pipelines bot commented Oct 9, 2023

mdh1418 left a comment

mkhamoyan commented Oct 9, 2023

[iOS][non-icu] HybridGlobalization implement japanese calendar data #92471

[iOS][non-icu] HybridGlobalization implement japanese calendar data #92471

Conversation

mkhamoyan commented Sep 22, 2023 • edited Loading

ghost commented Sep 22, 2023

mkhamoyan commented Sep 22, 2023

azure-pipelines bot commented Sep 22, 2023

ghost commented Sep 22, 2023

mkhamoyan commented Sep 25, 2023

azure-pipelines bot commented Sep 25, 2023

mdh1418 Oct 5, 2023

Choose a reason for hiding this comment

mkhamoyan Oct 5, 2023

Choose a reason for hiding this comment

mkhamoyan Oct 6, 2023

Choose a reason for hiding this comment

mdh1418 Oct 5, 2023 • edited Loading

Choose a reason for hiding this comment

mkhamoyan Oct 5, 2023

Choose a reason for hiding this comment

mkhamoyan commented Oct 6, 2023

azure-pipelines bot commented Oct 6, 2023

mkhamoyan commented Oct 9, 2023

azure-pipelines bot commented Oct 9, 2023

mdh1418 left a comment

Choose a reason for hiding this comment

mkhamoyan commented Oct 9, 2023

mkhamoyan commented Sep 22, 2023 •

edited

Loading

mdh1418 Oct 5, 2023 •

edited

Loading