Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workloads test: Install the current app.ref pack also #93571

Closed
wants to merge 3 commits into from
Closed

Workloads test: Install the current app.ref pack also #93571

wants to merge 3 commits into from

Conversation

radical
Copy link
Member

@radical radical commented Oct 16, 2023 •
edited
Loading

Re-enable updating the targeting pack as the workload is correctly using
9.0 artifacts. The targeting pack update is needed because it includes
the locally built analyzers, like the source generators for
JSImport/Export.

This fixes SatelliteLoadingTests.LoadSatelliteAssembly.

Fixes: #93387

@radical
Workloads test: Install the current app.ref pack also
01501ff 
Re-enable updating the targeting pack as the workload is correctly using
9.0 artifacts. The targeting pack update is needed because it includes
the locally built analyzers, like the source generators for
`JSImport/Export`.

This fixes `SatelliteLoadingTests.LoadSatelliteAssembly`.

Fixes issue: dotnet#93387
@radical radical added the arch-wasm WebAssembly architecture label Oct 16, 2023
@ghost
Copy link

ghost commented Oct 16, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Re-enable updating the targeting pack as the workload is correctly using
9.0 artifacts. The targeting pack update is needed because it includes
the locally built analyzers, like the source generators for
JSImport/Export.

This fixes SatelliteLoadingTests.LoadSatelliteAssembly.

Fixes issue: #93387

Author: radical
Assignees: -
Labels:

arch-wasm
Milestone: -

@radical radical requested a review from pavelsavara October 16, 2023 19:56
@ghost ghost assigned radical Oct 16, 2023
@radical radical requested review from lewing and maraf October 16, 2023 19:57
@ghost
Copy link

ghost commented Oct 16, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Re-enable updating the targeting pack as the workload is correctly using
9.0 artifacts. The targeting pack update is needed because it includes
the locally built analyzers, like the source generators for
JSImport/Export.

This fixes SatelliteLoadingTests.LoadSatelliteAssembly.

Fixes issue: #93387

Author: radical
Assignees: radical
Labels:

arch-wasm, area-Infrastructure-mono
Milestone: -

@radical radical marked this pull request as draft October 16, 2023 19:57
@radical radical marked this pull request as ready for review October 17, 2023 02:26
This was referenced Oct 17, 2023
Open
Closed
@radical
Copy link
Member Author

radical commented Oct 17, 2023

The failures are unrelated:

@radical
Copy link
Member Author

radical commented Oct 17, 2023

I will wait for #93066 which updates the SDK used for testing, then test this PR again, before merging.

@radical radical closed this Oct 17, 2023
@radical radical reopened this Oct 17, 2023
@radical
Copy link
Member Author

radical commented Oct 17, 2023

#93625 would be the preferable fix.

@lewing
Copy link
Member

lewing commented Oct 18, 2023

fixed in #93625

@lewing lewing closed this Oct 18, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pavelsavara pavelsavara pavelsavara approved these changes

@lewing lewing Awaiting requested review from lewing

@maraf maraf Awaiting requested review from maraf maraf is a code owner

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[browser][WBT] SatelliteLoadingTests.LoadSatelliteAssembly - ActiveIssue
3 participants
@radical @lewing @pavelsavara