Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workloads test: Install the current app.ref pack also #93571

Closed
wants to merge 3 commits into from
Closed

Workloads test: Install the current app.ref pack also #93571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01501ff
Workloads test: Install the current app.ref pack also
radical Oct 12, 2023
a1cb33a
Merge remote-tracking branch 'origin/main' into fix-app-ref-wbt
radical Oct 17, 2023
42f6601
[wasm] WBT: Disable NonWasmConsoleBuild_WithWorkload
radical Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion eng/testing/workloads-testing.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
GetWorkloadInputs;
_InstallWorkloads
</InstallWorkloadUsingArtifactsDependsOn>

<SkipUpdateAppRefPackForTestingWorkloads>false</SkipUpdateAppRefPackForTestingWorkloads>
</PropertyGroup>

<ItemGroup>
Expand Down Expand Up @@ -190,7 +192,7 @@
LocalNuGetsPath="$(LibrariesShippingPackagesDir)"
TemplateNuGetConfigPath="$(RepoRoot)NuGet.config"
SdkWithNoWorkloadInstalledPath="$(_SdkWithNoWorkloadPath)"
SkipUpdateAppRefPack="true"
SkipUpdateAppRefPack="$(SkipUpdateAppRefPackForTestingWorkloads)"
/>

<Touch Files="$(_SdkWithNoWorkloadStampPath)" AlwaysCreate="true" />
Expand Down
1 change: 1 addition & 0 deletions src/mono/wasm/Wasm.Build.Tests/NonWasmTemplateBuildTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ public void NonWasmConsoleBuild_WithoutWorkload(string config, string extraBuild
shouldRun: targetFramework == s_latestTargetFramework);

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/93585")]
[MemberData(nameof(GetTestData))]
public void NonWasmConsoleBuild_WithWorkload(string config, string extraBuildArgs, string targetFramework)
=> NonWasmConsoleBuild(config,
Expand Down
1 change: 0 additions & 1 deletion src/mono/wasm/Wasm.Build.Tests/TestAppScenarios/SatelliteLoadingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ public SatelliteLoadingTests(ITestOutputHelper output, SharedBuildPerTestClassFi
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/93387")]
public async Task LoadSatelliteAssembly()
{
CopyTestAsset("WasmBasicTestApp", "SatelliteLoadingTests");
Expand Down