Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Task.WhenAll #93619

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Add tests for Task.WhenAll #93619

merged 3 commits into from
Jan 30, 2024

Conversation

manandre
Copy link
Contributor

Follow the same pattern as used for Task.WhenAny in

runtime/src/libraries/System.Threading.Tasks/tests/MethodCoverage.cs

Lines 181 to 279 in c657cb0

[Fact]
public static void Task_WhenAny_TwoTasks_InvalidArgs_Throws()
{
AssertExtensions.Throws<ArgumentNullException>("task1", () => Task.WhenAny(null, Task.CompletedTask));
AssertExtensions.Throws<ArgumentNullException>("task2", () => Task.WhenAny(Task.CompletedTask, null));
AssertExtensions.Throws<ArgumentNullException>("task1", () => Task.WhenAny(null, Task.FromResult(1)));
AssertExtensions.Throws<ArgumentNullException>("task2", () => Task.WhenAny(Task.FromResult(2), null));
}
[Fact]
public static void Task_WhenAny_NoTasks_Throws()
{
AssertExtensions.Throws<ArgumentException>("tasks", () => { Task.WhenAny(new Task[0]); });
AssertExtensions.Throws<ArgumentException>("tasks", () => { Task.WhenAny(new List<Task>()); });
AssertExtensions.Throws<ArgumentException>("tasks", () => { Task.WhenAny(EmptyIterator<Task>()); });
AssertExtensions.Throws<ArgumentException>("tasks", () => { Task.WhenAny(new Task<int>[0]); });
AssertExtensions.Throws<ArgumentException>("tasks", () => { Task.WhenAny(new List<Task<int>>()); });
AssertExtensions.Throws<ArgumentException>("tasks", () => { Task.WhenAny(EmptyIterator<Task<int>>()); });
static IEnumerable<T> EmptyIterator<T>() { yield break; }
}
[Fact]
public static async Task Task_WhenAny_TwoTasks_OnePreCompleted()
{
Task<int> t1 = Task.FromResult(1);
Task<int> t2 = new TaskCompletionSource<int>().Task;
Assert.Same(t1, await Task.WhenAny((Task)t1, (Task)t2));
Assert.Same(t1, await Task.WhenAny((Task)t2, (Task)t1));
Assert.Same(t1, await Task.WhenAny(t1, t2));
Assert.Same(t1, await Task.WhenAny(t2, t1));
}
[Fact]
public static async Task Task_WhenAny_TwoTasks_BothPreCompleted()
{
Task<int> t1 = Task.FromResult(1);
Task<int> t2 = Task.FromResult(2);
Assert.Same(t1, await Task.WhenAny((Task)t1, (Task)t2));
Assert.Same(t1, await Task.WhenAny((Task)t1, (Task)t1));
Assert.Same(t2, await Task.WhenAny((Task)t2, (Task)t1));
Assert.Same(t1, await Task.WhenAny(t1, t2));
Assert.Same(t1, await Task.WhenAny(t1, t1));
Assert.Same(t2, await Task.WhenAny(t2, t1));
}
[Fact]
public static async Task Task_WhenAny_TwoTasks_WakesOnFirstCompletion()
{
// Non-generic, first completes
{
var t1 = new TaskCompletionSource<int>();
var t2 = new TaskCompletionSource<int>();
Task<Task> twa = Task.WhenAny((Task)t1.Task, (Task)t2.Task);
Assert.False(twa.IsCompleted);
t1.SetResult(42);
Assert.Same(t1.Task, await twa);
}
// Generic, first completes
{
var t1 = new TaskCompletionSource<int>();
var t2 = new TaskCompletionSource<int>();
Task<Task<int>> twa = Task.WhenAny(t1.Task, t2.Task);
Assert.False(twa.IsCompleted);
t1.SetResult(42);
Assert.Same(t1.Task, await twa);
}
// Non-generic, second completes
{
var t1 = new TaskCompletionSource<int>();
var t2 = new TaskCompletionSource<int>();
Task<Task> twa = Task.WhenAny((Task)t1.Task, (Task)t2.Task);
Assert.False(twa.IsCompleted);
t2.SetResult(42);
Assert.Same(t2.Task, await twa);
}
// Generic, second completes
{
var t1 = new TaskCompletionSource<int>();
var t2 = new TaskCompletionSource<int>();
Task<Task<int>> twa = Task.WhenAny(t1.Task, t2.Task);
Assert.False(twa.IsCompleted);
t2.SetResult(42);
Assert.Same(t2.Task, await twa);
}
}

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 17, 2023
@ghost
Copy link

ghost commented Oct 17, 2023

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

Follow the same pattern as used for Task.WhenAny in

runtime/src/libraries/System.Threading.Tasks/tests/MethodCoverage.cs

Lines 181 to 279 in c657cb0

[Fact]
public static void Task_WhenAny_TwoTasks_InvalidArgs_Throws()
{
AssertExtensions.Throws<ArgumentNullException>("task1", () => Task.WhenAny(null, Task.CompletedTask));
AssertExtensions.Throws<ArgumentNullException>("task2", () => Task.WhenAny(Task.CompletedTask, null));
AssertExtensions.Throws<ArgumentNullException>("task1", () => Task.WhenAny(null, Task.FromResult(1)));
AssertExtensions.Throws<ArgumentNullException>("task2", () => Task.WhenAny(Task.FromResult(2), null));
}
[Fact]
public static void Task_WhenAny_NoTasks_Throws()
{
AssertExtensions.Throws<ArgumentException>("tasks", () => { Task.WhenAny(new Task[0]); });
AssertExtensions.Throws<ArgumentException>("tasks", () => { Task.WhenAny(new List<Task>()); });
AssertExtensions.Throws<ArgumentException>("tasks", () => { Task.WhenAny(EmptyIterator<Task>()); });
AssertExtensions.Throws<ArgumentException>("tasks", () => { Task.WhenAny(new Task<int>[0]); });
AssertExtensions.Throws<ArgumentException>("tasks", () => { Task.WhenAny(new List<Task<int>>()); });
AssertExtensions.Throws<ArgumentException>("tasks", () => { Task.WhenAny(EmptyIterator<Task<int>>()); });
static IEnumerable<T> EmptyIterator<T>() { yield break; }
}
[Fact]
public static async Task Task_WhenAny_TwoTasks_OnePreCompleted()
{
Task<int> t1 = Task.FromResult(1);
Task<int> t2 = new TaskCompletionSource<int>().Task;
Assert.Same(t1, await Task.WhenAny((Task)t1, (Task)t2));
Assert.Same(t1, await Task.WhenAny((Task)t2, (Task)t1));
Assert.Same(t1, await Task.WhenAny(t1, t2));
Assert.Same(t1, await Task.WhenAny(t2, t1));
}
[Fact]
public static async Task Task_WhenAny_TwoTasks_BothPreCompleted()
{
Task<int> t1 = Task.FromResult(1);
Task<int> t2 = Task.FromResult(2);
Assert.Same(t1, await Task.WhenAny((Task)t1, (Task)t2));
Assert.Same(t1, await Task.WhenAny((Task)t1, (Task)t1));
Assert.Same(t2, await Task.WhenAny((Task)t2, (Task)t1));
Assert.Same(t1, await Task.WhenAny(t1, t2));
Assert.Same(t1, await Task.WhenAny(t1, t1));
Assert.Same(t2, await Task.WhenAny(t2, t1));
}
[Fact]
public static async Task Task_WhenAny_TwoTasks_WakesOnFirstCompletion()
{
// Non-generic, first completes
{
var t1 = new TaskCompletionSource<int>();
var t2 = new TaskCompletionSource<int>();
Task<Task> twa = Task.WhenAny((Task)t1.Task, (Task)t2.Task);
Assert.False(twa.IsCompleted);
t1.SetResult(42);
Assert.Same(t1.Task, await twa);
}
// Generic, first completes
{
var t1 = new TaskCompletionSource<int>();
var t2 = new TaskCompletionSource<int>();
Task<Task<int>> twa = Task.WhenAny(t1.Task, t2.Task);
Assert.False(twa.IsCompleted);
t1.SetResult(42);
Assert.Same(t1.Task, await twa);
}
// Non-generic, second completes
{
var t1 = new TaskCompletionSource<int>();
var t2 = new TaskCompletionSource<int>();
Task<Task> twa = Task.WhenAny((Task)t1.Task, (Task)t2.Task);
Assert.False(twa.IsCompleted);
t2.SetResult(42);
Assert.Same(t2.Task, await twa);
}
// Generic, second completes
{
var t1 = new TaskCompletionSource<int>();
var t2 = new TaskCompletionSource<int>();
Task<Task<int>> twa = Task.WhenAny(t1.Task, t2.Task);
Assert.False(twa.IsCompleted);
t2.SetResult(42);
Assert.Same(t2.Task, await twa);
}
}

Author: manandre
Assignees: -
Labels:

area-System.Threading, community-contribution
Milestone: -

@manandre manandre mentioned this pull request Oct 17, 2023
Closed
@ghost
Copy link

ghost commented Nov 13, 2023

Tagging subscribers to this area: @dotnet/area-system-threading-tasks
See info in area-owners.md if you want to be subscribed.

Issue Details

Follow the same pattern as used for Task.WhenAny in

runtime/src/libraries/System.Threading.Tasks/tests/MethodCoverage.cs

Lines 181 to 279 in c657cb0

[Fact]
public static void Task_WhenAny_TwoTasks_InvalidArgs_Throws()
{
AssertExtensions.Throws<ArgumentNullException>("task1", () => Task.WhenAny(null, Task.CompletedTask));
AssertExtensions.Throws<ArgumentNullException>("task2", () => Task.WhenAny(Task.CompletedTask, null));
AssertExtensions.Throws<ArgumentNullException>("task1", () => Task.WhenAny(null, Task.FromResult(1)));
AssertExtensions.Throws<ArgumentNullException>("task2", () => Task.WhenAny(Task.FromResult(2), null));
}
[Fact]
public static void Task_WhenAny_NoTasks_Throws()
{
AssertExtensions.Throws<ArgumentException>("tasks", () => { Task.WhenAny(new Task[0]); });
AssertExtensions.Throws<ArgumentException>("tasks", () => { Task.WhenAny(new List<Task>()); });
AssertExtensions.Throws<ArgumentException>("tasks", () => { Task.WhenAny(EmptyIterator<Task>()); });
AssertExtensions.Throws<ArgumentException>("tasks", () => { Task.WhenAny(new Task<int>[0]); });
AssertExtensions.Throws<ArgumentException>("tasks", () => { Task.WhenAny(new List<Task<int>>()); });
AssertExtensions.Throws<ArgumentException>("tasks", () => { Task.WhenAny(EmptyIterator<Task<int>>()); });
static IEnumerable<T> EmptyIterator<T>() { yield break; }
}
[Fact]
public static async Task Task_WhenAny_TwoTasks_OnePreCompleted()
{
Task<int> t1 = Task.FromResult(1);
Task<int> t2 = new TaskCompletionSource<int>().Task;
Assert.Same(t1, await Task.WhenAny((Task)t1, (Task)t2));
Assert.Same(t1, await Task.WhenAny((Task)t2, (Task)t1));
Assert.Same(t1, await Task.WhenAny(t1, t2));
Assert.Same(t1, await Task.WhenAny(t2, t1));
}
[Fact]
public static async Task Task_WhenAny_TwoTasks_BothPreCompleted()
{
Task<int> t1 = Task.FromResult(1);
Task<int> t2 = Task.FromResult(2);
Assert.Same(t1, await Task.WhenAny((Task)t1, (Task)t2));
Assert.Same(t1, await Task.WhenAny((Task)t1, (Task)t1));
Assert.Same(t2, await Task.WhenAny((Task)t2, (Task)t1));
Assert.Same(t1, await Task.WhenAny(t1, t2));
Assert.Same(t1, await Task.WhenAny(t1, t1));
Assert.Same(t2, await Task.WhenAny(t2, t1));
}
[Fact]
public static async Task Task_WhenAny_TwoTasks_WakesOnFirstCompletion()
{
// Non-generic, first completes
{
var t1 = new TaskCompletionSource<int>();
var t2 = new TaskCompletionSource<int>();
Task<Task> twa = Task.WhenAny((Task)t1.Task, (Task)t2.Task);
Assert.False(twa.IsCompleted);
t1.SetResult(42);
Assert.Same(t1.Task, await twa);
}
// Generic, first completes
{
var t1 = new TaskCompletionSource<int>();
var t2 = new TaskCompletionSource<int>();
Task<Task<int>> twa = Task.WhenAny(t1.Task, t2.Task);
Assert.False(twa.IsCompleted);
t1.SetResult(42);
Assert.Same(t1.Task, await twa);
}
// Non-generic, second completes
{
var t1 = new TaskCompletionSource<int>();
var t2 = new TaskCompletionSource<int>();
Task<Task> twa = Task.WhenAny((Task)t1.Task, (Task)t2.Task);
Assert.False(twa.IsCompleted);
t2.SetResult(42);
Assert.Same(t2.Task, await twa);
}
// Generic, second completes
{
var t1 = new TaskCompletionSource<int>();
var t2 = new TaskCompletionSource<int>();
Task<Task<int>> twa = Task.WhenAny(t1.Task, t2.Task);
Assert.False(twa.IsCompleted);
t2.SetResult(42);
Assert.Same(t2.Task, await twa);
}
}

Author: manandre
Assignees: -
Labels:

area-System.Threading.Tasks, community-contribution
Milestone: -

@ericstj
Copy link
Member

ericstj commented Nov 27, 2023

I merged in the rename from #94644 to resolve conflicts. @stephentoub can you have a look at these tests?

stephentoub
stephentoub approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for improving the test suite.

This was referenced Jan 29, 2024
Closed
Closed
Closed
Closed
@stephentoub stephentoub merged commit 28ad7e9 into dotnet:main Jan 30, 2024
111 checks passed
@manandre manandre deleted the whenall-tests branch January 30, 2024 18:03
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@kouvel kouvel Awaiting requested review from kouvel

Assignees
No one assigned
Labels
area-System.Threading.Tasks community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manandre @ericstj @stephentoub @mangod9