Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests from full facade folder to type forward destination #94644

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Nov 12, 2023

Fixes #89230

A previous changed moved full facade assemblies into src/libraries/shims but the tests were left in their original location.

  1. Move System.Data.DataSetExtensions/tests into System.Data.Common/tests and all other test projects under System.Runtime/tests.

  2. Update the tests.proj file that excludes based on the test project file paths.

  3. Delete System.AppContext/tests which already existed (as a copy)
    under System.Runtime/tests.

  4. Update System.Runtime.sln and System.Data.Common.sln

  5. Delete README.md files that are now unused and not required anymore.

Important: Exclude moved files from the diff. The actually changed files are less than 10.

@ghost
Copy link

ghost commented Nov 12, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #89230

A previous changed moved full facade assemblies into src/libraries/shims but the tests were left in their original location.

  1. Move System.Data.DataSetExtensions/tests into System.Data.Common/tests and all other test projects under System.Runtime/tests.

  2. Update the tests.proj file that excludes based on the test project file paths.

  3. Update System.Runtime.sln and System.Data.Common.sln

  4. Delete README.md files that are now unused and not required anymore.

Important: Exclude renamed files from the diff. The actually changed files are less than 10.

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries

Milestone: -

Fixes #89230

A previous changed moved full facade assemblies into src/libraries/shims
but the tests were left in their original location.

1. Move System.Data.DataSetExtensions/tests into System.Data.Common/tests
and all other test projects under System.Runtime/tests.

2. Update the tests.proj file that excludes based on the test project file
paths.

3. Delete System.AppContext/tests which already existed (as a copy)
   under System.Runtime/tests.

4. Update System.Runtime.sln and System.Data.Common.sln

5. Delete README.md files that are now unused and not required anymore.
@ViktorHofer ViktorHofer force-pushed the MoveTestsToFullFacadeTypeForwardDestination branch from c1ac3da to e80bc72 Compare November 13, 2023 12:20
@ViktorHofer ViktorHofer merged commit 71a7d88 into main Nov 13, 2023
106 of 110 checks passed
@ViktorHofer ViktorHofer deleted the MoveTestsToFullFacadeTypeForwardDestination branch November 13, 2023 13:54
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2023
@stephentoub
Copy link
Member

Is there a follow-on expected for this? I'm finding it very awkward that System.Runtime\tests contains a bunch of System.Xx.Tests folders. From my perspective, either the tests should be distributed to the appropriate locations in the single System.Runtime.Tests project, or we should move these folders back to the top-level under libraries.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move tests from full facade assemblies into type forward destination
3 participants